Skip to content

fix(windows): allow web fullscreen APIs to work - #13558

Merged
Legend-Master merged 4 commits into
tauri-apps:devfrom
Legend-Master:windows-fullscreen
Jun 3, 2025
Merged

fix(windows): allow web fullscreen APIs to work#13558
Legend-Master merged 4 commits into
tauri-apps:devfrom
Legend-Master:windows-fullscreen

Conversation

@Legend-Master

@Legend-Master Legend-Master commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

Reference: MicrosoftEdge/WebView2Feedback#1834

Fix #13557

I believe it works in this way on both Mac and Linux, so let's align this behavior on Windows as well

@Legend-Master
Legend-Master requested a review from a team as a code owner June 3, 2025 09:06
@github-actions

github-actions Bot commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

Package Changes Through 6cc8064

There are 8 changes which include tauri-bundler with minor, tauri with minor, tauri-cli with minor, tauri-codegen with minor, tauri-utils with minor, @tauri-apps/api with minor, @tauri-apps/cli with minor, tauri-runtime-wry with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.5.0 2.6.0
tauri-utils 2.4.0 2.5.0
tauri-bundler 2.4.0 2.5.0
tauri-runtime 2.6.0 2.6.1
tauri-runtime-wry 2.6.0 2.6.1
tauri-codegen 2.2.0 2.3.0
tauri-macros 2.2.0 2.2.1
tauri-plugin 2.2.0 2.2.1
tauri-build 2.2.0 2.2.1
tauri 2.5.1 2.6.0
@tauri-apps/cli 2.5.0 2.6.0
tauri-cli 2.5.0 2.6.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars

Copy link
Copy Markdown
Member

I'll check macos in an hour or so. I don't think it behaves like this but didn't check for ages

@Legend-Master

Copy link
Copy Markdown
Contributor Author

Since that's what the author said in #13557, I assumed it is the case, for Linux side, it seems to work like that in WSL at least

@FabianLars

Copy link
Copy Markdown
Member

i was so sure it worked like this on more platforms than just windows but i guess i didn't look closely enough when people talked about it in #support . And yes, can confirm that it's a proper fullscreen on macos. Which tbh is kinda sad, i'd imagine there are use cases for the current windows behavior.

@FabianLars FabianLars left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No access to Windows today, so untested approval.

@Legend-Master

Copy link
Copy Markdown
Contributor Author

I have tested a few times and it seems to work fine 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Video player native fullscreen (element fullscreen) not working, only web fullscreen available (except on macOS with macOSPrivateApi)

2 participants