fix(macos): run app.set_theme on main thread - #13443
Merged
Legend-Master merged 2 commits intoMay 15, 2025
Merged
Conversation
Contributor
Package Changes Through 6f241aeThere are 7 changes which include tauri-bundler with patch, tauri with minor, tauri-cli with patch, @tauri-apps/api with minor, tauri-utils with minor, @tauri-apps/cli with patch, tauri-runtime-wry with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Legend-Master
commented
May 14, 2025
Comment on lines
+2914
to
+2918
| self | ||
| .context | ||
| .main_thread | ||
| .window_target | ||
| .cursor_position() |
Contributor
Author
There was a problem hiding this comment.
I think this is not needed as Wry is !Send and can only be used on main thread so reverted it back
FabianLars
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #13439