Skip to content

fix(window): ensure set_window_effects runs on main thread in WindowBuilder (#13422) - #13423

Merged
FabianLars merged 3 commits into
tauri-apps:devfrom
kingsword09:fix-set-window-effects-main-thread
May 16, 2025
Merged

fix(window): ensure set_window_effects runs on main thread in WindowBuilder (#13422)#13423
FabianLars merged 3 commits into
tauri-apps:devfrom
kingsword09:fix-set-window-effects-main-thread

Conversation

@kingsword09

Copy link
Copy Markdown
Contributor

Ensure set_window_effects runs on main thread in WindowBuilder.

@kingsword09
kingsword09 requested a review from a team as a code owner May 13, 2025 03:10
@github-actions

github-actions Bot commented May 13, 2025

Copy link
Copy Markdown
Contributor

Package Changes Through b095046

There are 7 changes which include tauri-bundler with patch, tauri with minor, @tauri-apps/api with minor, tauri-utils with minor, tauri-cli with patch, @tauri-apps/cli with patch, tauri-runtime-wry with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.5.0 2.6.0
tauri-utils 2.4.0 2.5.0
tauri-bundler 2.4.0 2.4.1
tauri-runtime 2.6.0 2.6.1
tauri-runtime-wry 2.6.0 2.6.1
tauri-codegen 2.2.0 2.2.1
tauri-macros 2.2.0 2.2.1
tauri-plugin 2.2.0 2.2.1
tauri-build 2.2.0 2.2.1
tauri 2.5.1 2.6.0
@tauri-apps/cli 2.5.0 2.5.1
tauri-cli 2.5.0 2.5.1

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@Legend-Master Legend-Master linked an issue May 13, 2025 that may be closed by this pull request
@kingsword09
kingsword09 force-pushed the fix-set-window-effects-main-thread branch from 584c3d8 to 4fe4caa Compare May 13, 2025 07:04
@kingsword09
kingsword09 force-pushed the fix-set-window-effects-main-thread branch from 4fe4caa to f4ed86d Compare May 13, 2025 07:07
Comment thread .changes/fix-set-window-effects-main-thread.md
Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>
Comment thread crates/tauri/src/window/mod.rs Outdated

@Legend-Master Legend-Master left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, @FabianLars do you mind give it a try on a Mac to confirm if it's fixed 🙃?

@FabianLars

Copy link
Copy Markdown
Member

will do today, sry for the delay

@FabianLars FabianLars left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"today" is relative

@FabianLars
FabianLars merged commit 638804e into tauri-apps:dev May 16, 2025
@kingsword09
kingsword09 deleted the fix-set-window-effects-main-thread branch May 16, 2025 22:02
@chocochu

Copy link
Copy Markdown

thanks for the prompt fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] windowEffects not applied on new WebviewWindow()

4 participants