chore: fix helloworld example hang on Windows - #12992
Closed
WofWca wants to merge 1 commit into
Closed
Conversation
The issue was introduced in cedb24d (tauri-apps#12665). As the `.cookies()` docs state, the command should be async.
amrbashir
reviewed
Mar 15, 2025
amrbashir
left a comment
amrbashir
left a comment
Member
There was a problem hiding this comment.
Looks like the cookies thing slipped here accidentally, so lets remove that instead
WofWca
added a commit
to WofWca/tauri
that referenced
this pull request
Mar 16, 2025
Remove the cookies code from it. Firtly, they are not necessary: "Hello, world!" should be simple. Secondly, it's broken on Windows: `.cookies()` hangs. The cookies stuff was introduced recently, in cedb24d (tauri-apps#12665). This supersedes tauri-apps#12992.
WofWca
added a commit
to WofWca/tauri
that referenced
this pull request
Mar 16, 2025
Remove the cookies code from it. Firtly, they are not necessary: "Hello, world!" should be simple. Secondly, it's broken on Windows: `.cookies()` hangs. The cookies stuff was introduced recently, in cedb24d (tauri-apps#12665). This commit reverts the changes to the example. This supersedes tauri-apps#12992.
WofWca
added a commit
to WofWca/tauri
that referenced
this pull request
Mar 16, 2025
Remove the cookies code from it. Firtly, they are not necessary: "Hello, world!" should be simple. Secondly, it's broken on Windows: `.cookies()` hangs. The cookies stuff was introduced recently, in cedb24d (tauri-apps#12665). This commit reverts the changes to the example. This supersedes tauri-apps#12992.
Contributor
Author
|
Closed in favor of #12995 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was introduced in cedb24d (#12665).
As the
.cookies()docs state, the command should be async.I discovered the issue while I was preparing the report of #12990.
On a side note: I don't think that the cookies thing needs to be in the "helloworld" example.