Skip to content

fix: webview closing event error - #12935

Merged
amrbashir merged 4 commits into
tauri-apps:devfrom
tk103331:dev
Mar 10, 2025
Merged

fix: webview closing event error#12935
amrbashir merged 4 commits into
tauri-apps:devfrom
tk103331:dev

Conversation

@tk103331

@tk103331 tk103331 commented Mar 8, 2025

Copy link
Copy Markdown
Contributor

Fix webview closing event error

  Webview.getByLabel("sites_webview").then((webview) => {
    return webview.close();
  }

Using the above code will cause an error:
image
I found that the command name is wrong.It should be webview_close.

return invoke('plugin:webview|close', {

I tried the following code and it works:

  Webview.getByLabel("sites_webview").then((webview) => {
    return invoke('plugin:webview|webview_close', {
      label: "sites_webview"
    })
  }

@tk103331
tk103331 requested a review from a team as a code owner March 8, 2025 19:46

@amrbashir amrbashir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you add a change file in .changes directory and also run pnpm build inside packages/api ?

@github-actions

github-actions Bot commented Mar 9, 2025

Copy link
Copy Markdown
Contributor

Package Changes Through 1dfb886

There are 6 changes which include tauri with minor, @tauri-apps/api with minor, tauri-runtime-wry with minor, tauri-bundler with patch, tauri-cli with patch, @tauri-apps/cli with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.3.0 2.4.0
tauri-bundler 2.2.4 2.2.5
tauri-runtime-wry 2.4.1 2.5.0
tauri 2.3.1 2.4.0
@tauri-apps/cli 2.3.1 2.3.2
tauri-cli 2.3.1 2.3.2

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Comment thread .changes/fix-webview-close.md Outdated
Comment thread .changes/fix-webview-close.md Outdated
Comment thread .changes/fix-webview-close.md Outdated
Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>
@amrbashir
amrbashir merged commit 3a74dc8 into tauri-apps:dev Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants