Skip to content

fix: add windows to target_os of TaoWindowEvent::Focused (fix #9755) - #12014

Closed
kanatapple wants to merge 2 commits into
tauri-apps:devfrom
kanatapple:fix/add-target-focus-events
Closed

fix: add windows to target_os of TaoWindowEvent::Focused (fix #9755)#12014
kanatapple wants to merge 2 commits into
tauri-apps:devfrom
kanatapple:fix/add-target-focus-events

Conversation

@kanatapple

Copy link
Copy Markdown
Contributor

closes #9755

Fixed an issue where focus events would not fire when unstable feature was enabled in Windows.

@github-actions

github-actions Bot commented Jan 2, 2025

Copy link
Copy Markdown
Contributor

Package Changes Through 70a5cf7

There are 8 changes which include @tauri-apps/api with minor, tauri-bundler with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.1.1 2.2.0
tauri-utils 2.1.0 2.1.1
tauri-bundler 2.1.0 2.2.0
tauri-runtime 2.2.0 2.3.0
tauri-runtime-wry 2.2.0 2.3.0
tauri-codegen 2.0.3 2.0.4
tauri-macros 2.0.3 2.0.4
tauri-plugin 2.0.3 2.0.4
tauri-build 2.0.3 2.0.4
tauri 2.1.1 2.2.0
@tauri-apps/cli 2.1.0 2.2.0
tauri-cli 2.1.0 2.2.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Comment thread crates/tauri-runtime-wry/src/lib.rs Outdated
@FabianLars

Copy link
Copy Markdown
Member

Came here because of #11659 (comment) (cc @xuchaoqian). Unfortunetely i can't merge this yet (sorry for the useless commit). First if you have the unstable flag enabled your PR will print true and false on focus toggle unless you only click on the titlebar instead of the webview itself. This may be better than the current behavior of no event at all, but sadly it slightly breaks the Focused event if you don't have the unstable feature flag enabled, then it will emit the events twice.

@FabianLars
FabianLars marked this pull request as draft January 2, 2025 10:10
@kanatapple

Copy link
Copy Markdown
Contributor Author

@FabianLars
I apologize for the lack of confirmation.
It seems that I need to understand the core more to solve this problem... 😅

@lucasfernog

Copy link
Copy Markdown
Member

the complete solution is a bit more complicated, see #13222
thanks for the contribution though! you were in the right path :)

lucasfernog added a commit that referenced this pull request Apr 14, 2025
…ws (#13222)

* fix(tauri-runtime-wry): send focused events on multiwebview for Windows

closes #9755

follow-up for #12014

* fix mobile build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] tauri does not deliver WindowEvent::Focused when unstable feature is enabled

3 participants