Skip to content

fix(plugin): fix android_package_id to follow cli #10763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucasfernog merged 4 commits into from
Aug 26, 2024
+7 −4
Merged

fix(plugin): fix android_package_id to follow cli #10763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d0f4075
fix(plugin): fix android_package_id to follow cli
rdlabo Aug 25, 2024
dea51b4
Merge branch 'dev' into fix/example_android_package_id_follow_cli
rdlabo Aug 26, 2024
34db93c
Update tooling/cli/templates/plugin/src/mobile.rs
lucasfernog Aug 26, 2024
72b7359
add change file
lucasfernog Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/update-android-plugin-template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'tauri-cli': 'patch:changes'
'@tauri-apps/cli': 'patch:changes'
---

Update plugin template Android code to match documentation on Android package ID usage.
5 changes: 1 addition & 4 deletions tooling/cli/templates/plugin/src/mobile.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ use tauri::{

use crate::models::*;

#[cfg(target_os = "android")]
const PLUGIN_IDENTIFIER: &str = "{{ android_package_id }}";

#[cfg(target_os = "ios")]
tauri::ios_plugin_binding!(init_plugin_{{ plugin_name_snake_case }});

Expand All @@ -21,7 +18,7 @@ pub fn init<R: Runtime, C: DeserializeOwned>(
api: PluginApi<R, C>,
) -> crate::Result<{{ plugin_name_pascal_case }}<R>> {
#[cfg(target_os = "android")]
let handle = api.register_android_plugin(PLUGIN_IDENTIFIER, "ExamplePlugin")?;
let handle = api.register_android_plugin("{{ android_package_id }}", "ExamplePlugin")?;
#[cfg(target_os = "ios")]
let handle = api.register_ios_plugin(init_plugin_{{ plugin_name_snake_case }})?;
Ok({{ plugin_name_pascal_case }}(handle))
Expand Down