Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): parse --profile=<profile> syntax #10136

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir requested a review from a team as a code owner June 27, 2024 04:16
@bukowa
Copy link

bukowa commented Jun 27, 2024

Can we check for all flags not only profile?

@amrbashir
Copy link
Member Author

Our CLI arguments are parsed using clap crate which covers this syntax for us and so we don't need do it manually. However, we allow passing arbitrary args to the build runner (usually cargo) and these args could contain --profile which conflicts with --release flag that we pass internally so we need to avoid this conflict. In short, this is the only place we manually check for the flag and its value.

@lucasfernog lucasfernog merged commit 08f57ef into 1.x Jun 27, 2024
12 checks passed
@lucasfernog lucasfernog deleted the fix/cli/parse-profile-eq-syntax-1.x branch June 27, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants