Skip to content

fix(webdriver): windows: make native webdriver close with parent process (fix #8610) - #10108

Merged
lucasfernog merged 3 commits into
tauri-apps:devfrom
bukowa:tauri-driver-windows-jobobject
Apr 14, 2025
Merged

fix(webdriver): windows: make native webdriver close with parent process (fix #8610)#10108
lucasfernog merged 3 commits into
tauri-apps:devfrom
bukowa:tauri-driver-windows-jobobject

Conversation

@bukowa

@bukowa bukowa commented Jun 23, 2024

Copy link
Copy Markdown
Contributor

Closes #8610

I spent some time trying to figure this out, turns out it's much simpler that it seems! Works for me on windows.

@bukowa
bukowa requested a review from a team as a code owner June 23, 2024 21:29
@bukowa bukowa changed the title fix(webdriver): windows: make native webdriver close with parent process (fix https://github.com/tauri-apps/tauri/issues/8610) fix(webdriver): windows: make native webdriver close with parent process (fix #8610) Jun 23, 2024
bukowa added a commit to bukowa/ck3oop that referenced this pull request Jun 23, 2024
…windows

need PR: tauri-apps/tauri#10108

Signed-off-by: Bukowa <gitbukowa@gmail.com>
@amrbashir
amrbashir requested a review from chippers June 24, 2024 06:34
@bukowa bukowa closed this Jul 1, 2024
@bukowa bukowa reopened this Oct 1, 2024
@BryceBarbara

Copy link
Copy Markdown

@amrbashir Can you ensure this gets reviewed by someone?

@bukowa

bukowa commented Nov 11, 2024

Copy link
Copy Markdown
Contributor Author

It may need some changed, see ohadravid/win32job-rs#7

@github-actions

github-actions Bot commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

Package Changes Through 895814b

There are 9 changes which include @tauri-apps/api with minor, tauri with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-utils with minor, tauri-bundler with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-driver with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.4.1 2.5.0
tauri-utils 2.3.1 2.4.0
tauri-bundler 2.3.1 2.4.0
tauri-runtime 2.5.1 2.6.0
tauri-runtime-wry 2.5.1 2.6.0
tauri-codegen 2.1.1 2.1.2
tauri-macros 2.1.1 2.1.2
tauri-plugin 2.1.1 2.1.2
tauri-build 2.1.1 2.1.2
tauri 2.4.1 2.5.0
@tauri-apps/cli 2.4.1 2.5.0
tauri-cli 2.4.1 2.5.0
tauri-driver 2.0.3 2.0.4

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@lucasfernog lucasfernog left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@lucasfernog
lucasfernog merged commit 577c7ff into tauri-apps:dev Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] edge webdriver not closing in windows

3 participants