fix(cli/icon): return with an error instead of panic (#9638)

* fix(cli/icon): return with an error instead of panic closes #9636 * Update .changes/cli-icon-non-0-exit.md
tauri-apps · May 2, 2024 · 97ec422 · 97ec422
1 parent 7f6d269
commit 97ec422
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.changes/cli-icon-non-0-exit.md b/.changes/cli-icon-non-0-exit.md
@@ -0,0 +1,6 @@
+---
+"tauri-cli": "patch:bug"
+"@tauri-apps/cli": "patch:bug"
+---
+
+Exit `tauri icon` with non-zero code when it fails.
diff --git a/tooling/cli/src/icon.rs b/tooling/cli/src/icon.rs
@@ -138,11 +138,11 @@ pub fn command(options: Options) -> Result<()> {
       ))
     }
   } else {
-    panic!("Error loading image");
+    anyhow::bail!("Error loading image");
   };
 
   if source.height() != source.width() {
-    panic!("Source image must be square");
+    anyhow::bail!("Source image must be square");
   }
 
   if png_icon_sizes.is_empty() {