Skip to content

Fix sidecar docs link - #2794

Merged
vasfvitor merged 3 commits into
tauri-apps:v2from
simonhamp:patch-1
Oct 8, 2024
Merged

Fix sidecar docs link#2794
vasfvitor merged 3 commits into
tauri-apps:v2from
simonhamp:patch-1

Conversation

@simonhamp

Copy link
Copy Markdown
Contributor

Description

Fixes a broken link

@simonhamp
simonhamp requested a review from a team as a code owner October 4, 2024 10:07
@netlify

netlify Bot commented Oct 4, 2024

Copy link
Copy Markdown

Deploy Preview for tauri-v2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 48575ae
🔍 Latest deploy log https://app.netlify.com/sites/tauri-v2/deploys/6705b6e9d9f70100086831f9
😎 Deploy Preview https://deploy-preview-2794--tauri-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@dreyfus92 dreyfus92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @simonhamp, thank you for taking the time in contributing to Tauri Docs, if you head to the end of the mdx file you can find all the link refs and just add the missing trailing slash 😁

@simonhamp

Copy link
Copy Markdown
Contributor Author

Nope... I'm getting this when I follow the link in Chrome. But when I add the slash (as per the link that the nav menu uses), I have no problem seeing the page

Screenshot 2024-10-04 at 18 51 16

@dreyfus92

Copy link
Copy Markdown
Member

@vasfvitor have you noticed this problem?

@vasfvitor

Copy link
Copy Markdown
Contributor

@vasfvitor have you noticed this problem?

not personally, but we've been having issues with trailing slash around the docs and I haven't found a definitive fix, we've been manually updating our links but a few passed by.

note that I can't reproduce it

for this situation I guess it should be just to add the trailing slash on the link at the of the mdx file

@simonhamp

Copy link
Copy Markdown
Contributor Author

That's what this PR does 😉

@vasfvitor
vasfvitor merged commit ed48763 into tauri-apps:v2 Oct 8, 2024
FabianLars pushed a commit that referenced this pull request Aug 20, 2026
Co-authored-by: Vitor Ayres <gitkey@virtuaires.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants