Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(features): update /features/fs page #1888

Merged
merged 9 commits into from
Feb 27, 2024

Conversation

pewsheen
Copy link
Contributor

What kind of changes does this PR include?

  • New or updated content
    • Update /features/fs content

Description

  • What does this PR change? Give us a brief description.
    • Update /features/fs content

I started thinking listing the permission is a bad idea 🤣
Maybe we could paste a link to a auto-generated permission list in plugins-workspace, like https://github.com/tauri-apps/plugins-workspace/blob/v2/plugins/fs/permissions/autogenerated/reference.md

Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for tauri-docs-starlight ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5a41a58
🔍 Latest deploy log https://app.netlify.com/sites/tauri-docs-starlight/deploys/65ddce0fd2118f00084b4016
😎 Deploy Preview https://deploy-preview-1888--tauri-docs-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@dklassic
Copy link
Contributor

Haha that list sure is painfully long to go through

Copy link
Contributor

@dklassic dklassic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except some formatting and consistency nitpicking around.

@dklassic dklassic merged commit 44e2914 into tauri-apps:next Feb 27, 2024
3 checks passed
@dklassic
Copy link
Contributor

dklassic commented Feb 27, 2024

So CI auto formatting seems to break the permission list in production, salvaging now.

Should be fixed in:

@pewsheen pewsheen deleted the docs/features/fs branch February 27, 2024 12:13
@dklassic
Copy link
Contributor

Closed #1478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants