-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create Directory.astro
component
#1717
Conversation
✅ Deploy Preview for tauri-docs-starlight ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Have a few thoughts on this but going to put them in Discord for us to chat through when you're online: https://discord.com/channels/616186924390023171/662624589037436928/1179737597925392434 |
Features.astro
to handle i18n and receive propsDirectory.astro
component
I wonder if this should also respect |
good point, yes |
DO NOT MERGE Updates:
Anything else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just put a few general feedback comments. Overall pretty happy with this. There's a few moving parts upstream with the Badge in a LinkCard, but happy to merge this when you're ready and just refactor when those land.
64c8ee9
to
be169e6
Compare
Happy with this overall. I think the final piece is putting it in place on the respective pages in this PR so we can double-check that we're happy with the results. |
had to add a filter by filename, how do you feel of having both options( |
I would do |
done, anything else? |
Looks good. I think the |
Awesome! Let's get this merged in 💪 |
What kind of changes does this PR include?
Description
This is updated so It can be both be used in the current situation and in the migration list or elsewhere.
For reference: #1670 (comment)
Usage:
I chose for now to make
locale
mandatory so it's clear that it is needed on translated pages. With a bit of more work it could be removed by matchingpath
tolocales.json
but first I want to put this out here to gather feedback on which direction should this go.Currently, on i18n pages, first is rendered translated cards and then fallback pages, excluding translated. Another possibility is to leave them mixed, in which Notifications card would be down below.
"(en)" is for clarity, but I do think something to indicate it's fallback is nice to have.
Preview:
Another use case:
I think before merging, it should be decided this will be the same component in the aforementioned issue comment or change it's name.
Thank you.