Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 migration: guides/test to next #1686

Merged
merged 28 commits into from
Dec 21, 2023

Conversation

vasfvitor
Copy link
Contributor

@vasfvitor vasfvitor commented Nov 15, 2023

What kind of changes does this PR include?

  • New or updated content
  • Changes to the docs site code

Description

Pages:
https://tauri.app/v1/guides/testing/mocking
https://tauri.app/v1/guides/testing/webdriver/introduction
https://tauri.app/v1/guides/testing/webdriver/example/setup
https://tauri.app/v1/guides/testing/webdriver/example/selenium
https://tauri.app/v1/guides/testing/webdriver/example/webdriverio
https://tauri.app/v1/guides/testing/webdriver/ci

TODO:

  • Copy i18n pages (if any)
  • Update internal links
  • Improve navigation structure
  • Fix image in /example/setup.md
  • Add redirects

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for tauri-docs-starlight ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6f26211
🔍 Latest deploy log https://app.netlify.com/sites/tauri-docs-starlight/deploys/6583820d866feb0008edfbe8
😎 Deploy Preview https://deploy-preview-1686--tauri-docs-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100
Accessibility: 100
Best Practices: 100
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@lorenzolewis
Copy link
Member

Will get #1670 worked through first then will take a look at this.

@vasfvitor vasfvitor changed the title Draft: Migrate guides/test to next Draft: v2 migration: guides/test to next Dec 5, 2023
@vasfvitor vasfvitor marked this pull request as ready for review December 12, 2023 04:36
@github-actions github-actions bot added the i18n Is this related to translations? label Dec 12, 2023
Copy link
Contributor Author

@vasfvitor vasfvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i18n pages that had only 1 or 2 sentences translated were left behind.

tsconfig.json Show resolved Hide resolved
[`mockipc()`]: https://tauri.app/v1/api/js/mocks#mockipc
[`mockwindows()`]: https://tauri.app/v1/api/js/mocks#mockwindows
[`clearmocks()`]: https://tauri.app/v1/api/js/mocks#clearmocks
[vitest]: https://vitest.dev
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

links to v1 api docs, after a two seconds quick search I didn't find on v2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lorenzolewis
Copy link
Member

Once we get some clarity on mocks in V2 then this looks good to go to me.

@vasfvitor vasfvitor changed the title Draft: v2 migration: guides/test to next v2 migration: guides/test to next Dec 12, 2023
@lorenzolewis
Copy link
Member

I raised this with the dev team. Let's go ahead and keep the links to v1 like we have for now. With that in mind is this one good to merge from your perspective?

@vasfvitor
Copy link
Contributor Author

Updated some links and added TODO to update v2 links. I think it's ready. No need to place i18nReady right?

@lorenzolewis
Copy link
Member

Nope, no i18nReady on any of these since we're just doing a shift and not editing the content (wouldn't want to change it and then have someone translate things that will just be modified in the future).

Once we get closer to v2 beta is probably when we'll do an overall check to make sure everything covered is relevant and correct for v2 (and note where not).

@lorenzolewis lorenzolewis merged commit b1541c8 into tauri-apps:next Dec 21, 2023
7 checks passed
@lorenzolewis lorenzolewis mentioned this pull request Dec 21, 2023
@vasfvitor vasfvitor deleted the migrate-guides-testing branch December 24, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Is this related to translations?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants