Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use [email protected] to avoid a serious bug #1536

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

UnsolvedCypher
Copy link
Contributor

What kind of changes does this PR include?

  • Update to version of a referenced library

Description

The docs currently suggest using the latest version of the internal-ip library. However, version 8.0.0 has a serious bug and I've updated the docs to recommend 7.0.0.

@netlify
Copy link

netlify bot commented Sep 10, 2023

Deploy Preview for tauri-docs-starlight ready!

Name Link
🔨 Latest commit 06384bf
🔍 Latest deploy log https://app.netlify.com/sites/tauri-docs-starlight/deploys/650c33ef38986400085a1db5
😎 Deploy Preview https://deploy-preview-1536--tauri-docs-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@simonhyll
Copy link
Contributor

Now the question is: how fast do we think it'll be resolved. Because merging this also means we gotta put a reminder somewhere about removing it once they patch the bug. I like providing users with the best available information, the question is just if we want to make this the modus operandi for the project in general or not, because there is no way we're gonna be able to keep up with all these kind of bugs for all dependencies everywhere

Seeing as there is already a PR for a fix, I'm not sure this is worth bringing up, but then again, it's been waiting for merging for a while now 🤔 sindresorhus/internal-ip#49

@lorenzolewis lorenzolewis requested a review from a team September 12, 2023 16:21
@lorenzolewis
Copy link
Member

One way I've been tracking some of these things (although mainly for internal issues/PRs) is to link to the issue/PR inline as a comment in the copy:

{ /* Link to issue */ }

and then adding it to #1344

Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't look like it will be resolved upstream anytime soon so let's just merge this since users are actively hitting this issue.

p.s. thanks for the contribution :)

Edit: I added it to 1344

@FabianLars FabianLars merged commit 001f6d3 into tauri-apps:next Sep 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants