fix(ios): handle layout while view is detached - #1270
Merged
FabianLars merged 2 commits intoJul 21, 2026
Conversation
Avoid querying window geometry while UIKit is laying out detached view. View will report geometry after reattachment. fixes tauri-apps#1269
Contributor
Package Changes Through 40a565eThere are 1 changes which include tao with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
FabianLars
reviewed
Jul 21, 2026
| assert!(!window.is_null()); | ||
| // UIKit can lay out a view while it is detached during window and view-controller | ||
| // transitions. There is no window ID or screen geometry to report until reattachment. | ||
| if window.is_null() { |
Member
There was a problem hiding this comment.
we really need some tracing or something in the ios code in the future. all these assert/assert_eq calls are giving me anxiety.
Member
|
Thanks :) could you also add a small changefile please? (check .changes dir) |
FabianLars
approved these changes
Jul 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid querying window geometry while UIKit is laying out detached view. View will report geometry after reattachment.
fixes #1269