Skip to content

Fix(linux): JIS key mapping - #1228

Merged
pewsheen merged 2 commits into
tauri-apps:devfrom
ushinohama966:fix/linux-jis-key-mapping
May 30, 2026
Merged

Fix(linux): JIS key mapping#1228
pewsheen merged 2 commits into
tauri-apps:devfrom
ushinohama966:fix/linux-jis-key-mapping

Conversation

@ushinohama966

Copy link
Copy Markdown
Contributor

Description

This PR adds missing mappings for Japanese (JIS) keyboard specific keys (Zenkaku_Hankaku, Hiragana_Katakana, Henkan, and Muhenkan) in raw_key_to_key for the GTK backend.

Without this mapping, pressing these keys on Linux environments causes them to fall back to Key::Unidentified, leading to unexpected behaviors or warning logs in frontend event handlers.

@ushinohama966
ushinohama966 requested a review from a team as a code owner May 30, 2026 01:19
@github-actions

github-actions Bot commented May 30, 2026

Copy link
Copy Markdown
Contributor

Package Changes Through 0718d67

There are 1 changes which include tao with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tao 0.35.3 0.35.4

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@pewsheen pewsheen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good! Thanks!

@pewsheen

Copy link
Copy Markdown
Contributor

@ushinohama966 Could you follow https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits to sign your commit? otherwise we can't merge this PR.

@ushinohama966
ushinohama966 force-pushed the fix/linux-jis-key-mapping branch from ceb0335 to 0718d67 Compare May 30, 2026 10:30
@ushinohama966

Copy link
Copy Markdown
Contributor Author

@pewsheen Thank you for the feedback!
I have updated the commits to be GPG/SSH signed as requested. I have also verified that all commits in this PR now have the "Verified" status.

@pewsheen
pewsheen merged commit 47d38f3 into tauri-apps:dev May 30, 2026
20 checks passed
@github-actions github-actions Bot mentioned this pull request May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants