fix(wayland): decoration not clickable when initial visible is false - #1055
Closed
yuezk wants to merge 1 commit into
Closed
fix(wayland): decoration not clickable when initial visible is false#1055yuezk wants to merge 1 commit into
yuezk wants to merge 1 commit into
Conversation
Contributor
Package Changes Through 6f278c7There are 1 changes which include tao with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
I can reproduce this bug on Fedora (KDE Plasma 6.5.5, Wayland) in How can we merge it? |
dgerhardt
added a commit
to dgerhardt/tao
that referenced
this pull request
May 7, 2026
The default client side decoration handling of GTK is now used once again. Custom CSD don't make any sense when no custom widgets are added to the title bar. Futhermore, the custom CSD didn't work correctly and introduced multiple bugs regarding the titlebar and server-side rendering on Wayland. This is mostly a revert of tauri-apps#979. Fixes tauri-apps#1046, tauri-apps/tauri#13749, tauri-apps/tauri#14251, tauri-apps/tauri#14748 Supersedes tauri-apps#1055
dgerhardt
added a commit
to dgerhardt/tao
that referenced
this pull request
May 7, 2026
The default client side decoration handling of GTK is now used once again. Custom CSD don't make any sense when no custom widgets are added to the title bar. Futhermore, the custom CSD didn't work correctly and introduced multiple bugs regarding the titlebar and server-side rendering on Wayland. This is mostly a revert of tauri-apps#979. Fixes tauri-apps#1046, tauri-apps/tauri#13749, tauri-apps/tauri#14251, tauri-apps/tauri#14748 Supersedes tauri-apps#1055
FabianLars
added a commit
that referenced
this pull request
Jun 29, 2026
…cessary (#1218) * fix(wayland): remove broken custom CSD The default client side decoration handling of GTK is now used once again. Custom CSD don't make any sense when no custom widgets are added to the title bar. Futhermore, the custom CSD didn't work correctly and introduced multiple bugs regarding the titlebar and server-side rendering on Wayland. This is mostly a revert of #979. Fixes #1046, tauri-apps/tauri#13749, tauri-apps/tauri#14251, tauri-apps/tauri#14748 Supersedes #1055 * fix(wayland): propagate window events for CSD This reverts #941, which broke CSD event handling on Wayland. A new fix for #939 might now be needed. Fixes tauri-apps/tauri#13440 Might fix (unconfirmed) tauri-apps/tauri#11856 * fix(wayland): ensure compositors don't force decorations This enables CSD for undecorated windows to ensure that compositors with server-side decoration support (e.g. KDE Plasma) do not apply them when decorations are disabled for the window. Changing the decoration state for existing windows is however still not supported. This is a workaround for a GTK bug: https://gitlab.gnome.org/GNOME/gtk/-/work_items/5479 Fixes #899, tauri-apps/tauri#6562 * chore: add changelog entry for Wayland CSD fixes * fix(linux): reapply maximize fix from #979 This ensures that the window is resizable before maximizing it to avoid unexpected behavior. * Revert "fix(wayland): propagate window events for CSD" This reverts commit 25edb8e. * Reapply "fix(wayland): propagate window events for CSD" This reverts commit 6b11c08. * enable min/max buttons * prevent crash on wsl/weston when maximizing undecorated window * prevent duplicate mouse events * keep default decorations --------- Co-authored-by: Fabian-Lars <30730186+FabianLars@users.noreply.github.com>
Member
|
fixed in #1218 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The decoration is not clickable if the window initial visible is
false.Reproduce
Solution
Avoid setting the above child property of the
EventBox. The default value isfalse. Seems there is no need to set it totrue.https://docs.gtk.org/gtk3/method.EventBox.set_above_child.html