fix: MenuItem::Quit on Windows (#303)

* fix: `MenuItem::Close` on Windows * use `PostQuitMessage` instead Co-authored-by: amrbashir <[email protected]>
tauri-apps · Feb 4, 2022 · cf3d3b5 · cf3d3b5
1 parent 7811284
commit cf3d3b5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/.changes/fix-quit-menuitem-windows.md b/.changes/fix-quit-menuitem-windows.md
@@ -0,0 +1,5 @@
+---
+"tao": patch
+---
+
+Fixes the `MenuItem::Quit` behavior on Windows.
diff --git a/src/platform_impl/windows/event_loop.rs b/src/platform_impl/windows/event_loop.rs
@@ -222,7 +222,7 @@ impl<T: 'static> EventLoop<T> {
         .p
         .runner_shared
         .set_event_handler(move |event, control_flow| {
-          event_handler(event, event_loop_windows_ref, control_flow)
+          event_handler(event, event_loop_windows_ref, control_flow);
         });
     }
 

diff --git a/src/platform_impl/windows/menu.rs b/src/platform_impl/windows/menu.rs
@@ -341,6 +341,7 @@ pub(crate) unsafe extern "system" fn subclass_proc(
         }
         QUIT_ID => {
           subclass_input.send_event(Event::LoopDestroyed);
+          PostQuitMessage(0);
         }
         MINIMIZE_ID => {
           ShowWindow(hwnd, SW_MINIMIZE);