Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(updater) support proxy #891

Merged
merged 4 commits into from
Jan 17, 2024
Merged

feat(updater) support proxy #891

merged 4 commits into from
Jan 17, 2024

Conversation

zhangsan946
Copy link
Contributor

to close #887

@zhangsan946 zhangsan946 requested a review from a team as a code owner January 13, 2024 04:50
amrbashir
amrbashir requested changes Jan 16, 2024
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions, just a few changes needed.

plugins/updater/src/updater.rs Outdated Show resolved Hide resolved
plugins/updater/src/updater.rs Outdated Show resolved Hide resolved
plugins/updater/src/updater.rs Outdated Show resolved Hide resolved
plugins/updater/src/updater.rs Outdated Show resolved Hide resolved
plugins/updater/src/updater.rs Outdated Show resolved Hide resolved
@zhangsan946
Copy link
Contributor Author

@amrbashir please take a check again.

@amrbashir
Copy link
Member

Thank you

zhangsan946 and others added 4 commits January 17, 2024 16:39
@amrbashir amrbashir merged commit 4e2e775 into tauri-apps:v2 Jan 17, 2024
20 checks passed
@FabianLars FabianLars mentioned this pull request Jul 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangsan946 @amrbashir