Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to alpha.17, typed mobile plugin IPC arguments #676

Merged
merged 23 commits into from
Oct 29, 2023

Conversation

lucasfernog
Copy link
Member

Updates to the in progress typed IPC arguments that will be released on alpha.17.

Needs tauri-apps/tauri#8076

@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@tauri-apps/cli 2.0.0-alpha.16...2.0.0-alpha.17 None +0/-0 185 kB tauri-apps-ci-user
@tauri-apps/api 2.0.0-alpha.9...2.0.0-alpha.11 None +0/-0 347 kB tauri-apps-ci-user

@lucasfernog lucasfernog changed the title feat: typed mobile plugin IPC arguments feat: update to alpha.17, typed mobile plugin IPC arguments Oct 29, 2023
@lucasfernog lucasfernog marked this pull request as ready for review October 29, 2023 11:56
@lucasfernog lucasfernog requested a review from a team as a code owner October 29, 2023 11:56
plugins/notification/guest-js/index.ts Outdated Show resolved Hide resolved
@@ -511,7 +511,7 @@ mod tests {
assert_eq!(String::from_utf8(output.stdout).unwrap(), "");
assert_eq!(
String::from_utf8(output.stderr).unwrap(),
"cat: test/: Is a directory\n"
"cat: test/: Is a directory\n\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does that sound okay? why does it have two new lines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the std one only gives us a single \n so it's a bug on our end (it was already a bug, since it had a \n where it shouldn't, I guess someone just fixed the test instead of the actual bug). We should track this on the tauri repo (v1 and v2).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@lucasfernog lucasfernog requested a review from amrbashir October 29, 2023 17:09
@lucasfernog lucasfernog merged commit e438e0a into v2 Oct 29, 2023
1 check passed
@lucasfernog lucasfernog deleted the feat/typed-mobile-args branch October 29, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants