-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to alpha.17, typed mobile plugin IPC arguments #676
Conversation
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
@@ -511,7 +511,7 @@ mod tests { | |||
assert_eq!(String::from_utf8(output.stdout).unwrap(), ""); | |||
assert_eq!( | |||
String::from_utf8(output.stderr).unwrap(), | |||
"cat: test/: Is a directory\n" | |||
"cat: test/: Is a directory\n\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does that sound okay? why does it have two new lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the std one only gives us a single \n so it's a bug on our end (it was already a bug, since it had a \n where it shouldn't, I guess someone just fixed the test instead of the actual bug). We should track this on the tauri repo (v1 and v2).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool
Co-authored-by: Amr Bashir <[email protected]>
Updates to the in progress typed IPC arguments that will be released on alpha.17.
Needs tauri-apps/tauri#8076