fix(deep-link): update the Exec= in handler if the executable path changes - #3019
Conversation
FabianLars
left a comment
There was a problem hiding this comment.
Thanks for the PR! This is indeed how it's supposed to work and how it used to work until we added the ini crate i think.
Can you also add a small changefile please? Similar to https://github.com/tauri-apps/plugins-workspace/pull/3018/files#diff-6e7dd8c86c89bc4897dc64adef7ec8eb12a051e59696f039fb9d1e63dbaa928f but with deep-link instead of opener.
Should now be done! Let me know if I should make any more changes |
Package Changes Through a6475e2There are 6 changes which include deep-link with patch, deep-link-js with patch, geolocation with patch, geolocation-js with patch, updater with minor, updater-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Nope, you're done. Thanks! For the next PR (🥹) we'd appreciate it if you could configure commit signing though. In theory we require this in our repos but since it's annoying to sign past commits i'll abuse my permissions and merge it anyway. |
I noticed that deep-linking recently broke on my test application in Linux and debugged it to our project folder structure was reorganized leading to the executable path being different. The deep-linking plugin today doesn't check if the Exec field is different and requires it to be deleted manually in order to properly update.
This PR updates the
registerfunction to consider if theExecpath has changed and will update it if needed.