Skip to content

fix(deep-link): update the Exec= in handler if the executable path changes - #3019

Merged
FabianLars merged 4 commits into
tauri-apps:v2from
kevinschoonover:kevinschoonover/fix-new-exec
Oct 1, 2025
Merged

fix(deep-link): update the Exec= in handler if the executable path changes#3019
FabianLars merged 4 commits into
tauri-apps:v2from
kevinschoonover:kevinschoonover/fix-new-exec

Conversation

@kevinschoonover

Copy link
Copy Markdown
Contributor

I noticed that deep-linking recently broke on my test application in Linux and debugged it to our project folder structure was reorganized leading to the executable path being different. The deep-linking plugin today doesn't check if the Exec field is different and requires it to be deleted manually in order to properly update.

This PR updates the register function to consider if the Exec path has changed and will update it if needed.

@kevinschoonover
kevinschoonover requested a review from a team as a code owner September 30, 2025 05:09
Comment thread plugins/deep-link/src/template.desktop

@FabianLars FabianLars left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This is indeed how it's supposed to work and how it used to work until we added the ini crate i think.

Can you also add a small changefile please? Similar to https://github.com/tauri-apps/plugins-workspace/pull/3018/files#diff-6e7dd8c86c89bc4897dc64adef7ec8eb12a051e59696f039fb9d1e63dbaa928f but with deep-link instead of opener.

Comment thread plugins/deep-link/src/template.desktop
@kevinschoonover

Copy link
Copy Markdown
Contributor Author

Thanks for the PR! This is indeed how it's supposed to work and how it used to work until we added the ini crate i think.

Can you also add a small changefile please? Similar to https://github.com/tauri-apps/plugins-workspace/pull/3018/files#diff-6e7dd8c86c89bc4897dc64adef7ec8eb12a051e59696f039fb9d1e63dbaa928f but with deep-link instead of opener.

Should now be done! Let me know if I should make any more changes

@github-actions

github-actions Bot commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

Package Changes Through a6475e2

There are 6 changes which include deep-link with patch, deep-link-js with patch, geolocation with patch, geolocation-js with patch, updater with minor, updater-js with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.36 2.0.37
api-example-js 2.0.32 2.0.33
deep-link-example-js 2.2.6 2.2.7
deep-link 2.4.3 2.4.4
deep-link-js 2.4.3 2.4.4
geolocation 2.3.0 2.3.1
geolocation-js 2.3.0 2.3.1
single-instance 2.3.4 2.3.5
updater 2.9.0 2.10.0
updater-js 2.9.0 2.10.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Comment thread plugins/deep-link/src/lib.rs Outdated
Comment thread .changes/deep-link-fix-different-exec.md
@FabianLars

Copy link
Copy Markdown
Member

Let me know if I should make any more changes

Nope, you're done. Thanks!

For the next PR (🥹) we'd appreciate it if you could configure commit signing though. In theory we require this in our repos but since it's annoying to sign past commits i'll abuse my permissions and merge it anyway.

@FabianLars
FabianLars merged commit e25a933 into tauri-apps:v2 Oct 1, 2025
14 of 16 checks passed
@kevinschoonover
kevinschoonover deleted the kevinschoonover/fix-new-exec branch October 2, 2025 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants