feat(autostart): remove &'static constraint for init(args) parameter - #2909
feat(autostart): remove &'static constraint for init(args) parameter#2909WSH032 wants to merge 2 commits into
&'static constraint for init(args) parameter#2909Conversation
|
i think this change is fine. that said, i'd remove the args argument in v3, doesn't make sense to me here and the Builder should be used if args need to be set. |
Package Changes Through b63c58eThere are 10 changes which include autostart with minor, autostart-js with minor, fs with patch, fs-js with patch, nfc with patch, nfc-js with patch, opener with minor, opener-js with minor, store with minor, store-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Co-authored-by: Fabian-Lars <github@fabianlars.de>
|
I would probably prefer keeping this function as is so we don't breaking anything and remove it in v3, the builder was added for the exact reason because this function is not very ergonomic (forces you to pass in If we don't remove it, we probably want to remove all the parameters and making it just an alias to |
|
I agree with @Legend-Master's opinion (There should be one-- and preferably only one --obvious way to do it. --Zen of Python). Having both So, let's close this PR? |
The
&'static strmakesfn initalmost useless for FFI scenarios. Therefore, I replaced it withIntoIterator<Item = impl Into<String>>, but this could be a breaking change.What does the Tauri team think about this? If semantic compatibility prevents this improvement in v2, I am ok with temporarily implementing a new
initdownstream using aBuilder.