Skip to content

feat(updater): support bundle-specific targets - #2624

Merged
lucasfernog merged 64 commits into
tauri-apps:v2from
kandrelczyk:feature/fallback_targets
Aug 26, 2025
Merged

feat(updater): support bundle-specific targets#2624
lucasfernog merged 64 commits into
tauri-apps:v2from
kandrelczyk:feature/fallback_targets

Conversation

@kandrelczyk

Copy link
Copy Markdown
Contributor

Here are the changes for updater to handle #2277

I'm using the patched __TAURI_BUNDLE_TYPE variable to download the proper installer with fallback as described in #2277.

I've added some additional test on both Linux and Windows. Not sure if something needs to be done on other platforms.

@kandrelczyk
kandrelczyk requested a review from a team as a code owner April 11, 2025 21:07
@github-actions

github-actions Bot commented Apr 12, 2025

Copy link
Copy Markdown
Contributor

Package Changes Through abcee1f

There are 2 changes which include updater with minor, updater-js with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.35 2.0.36
api-example-js 2.0.31 2.0.32
updater 2.9.0 2.10.0
updater-js 2.9.0 2.10.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@kandrelczyk

Copy link
Copy Markdown
Contributor Author

Windows and Linux tests are failing because they require tauri-cli with tauri-apps/tauri#13209 change.

MacOS test is failing because of some compliation issue. I will have access to a mac next week so I will fix it.

@FabianLars

Copy link
Copy Markdown
Member

MacOS test is failing because of some compliation issue. I will have access to a mac next week so I will fix it.

It looks like you ran cargo update - if you revert the Cargo.lock file changes it should compile again.

Comment thread plugins/updater/src/lib.rs Outdated
Comment thread plugins/updater/src/updater.rs Outdated
@FabianLars

Copy link
Copy Markdown
Member

Addressed the comments.

Not all of them yet :)
In case it's github's UI being weird again, here are the ones i saw:
#2624 (comment)
#2624 (comment)
#2624 (comment)
#2624 (comment)
#2624 (comment)

Comment thread plugins/updater/src/error.rs
@kandrelczyk

Copy link
Copy Markdown
Contributor Author

@FabianLars checked all the comments again. Some of them I would rather leave for another PR (better to finally merge this and keep working in a clean branch). I moved the bundle type to a pure function. The only unaddressed comment is the one about mixed up responsibilities but I don't know what specifically should be changed there. Any ideas?

@lucasfernog

Copy link
Copy Markdown
Member

I think we can release this one next week

@Legend-Master

Copy link
Copy Markdown
Contributor

I have reverted the tauri bumps to align with the main branch, and since we have already bumped the workspace tauri requirement to 2.8 in main branch, we can remove the separate bump in the updater plugin now

@FabianLars

Copy link
Copy Markdown
Member

after merging this, please wait with the release until we support the {{}} url thingy too :) i feel like it doesn't make sense to not release them together.

@lucasfernog
lucasfernog merged commit 9ac5fe8 into tauri-apps:v2 Aug 26, 2025
150 checks passed
@kandrelczyk

Copy link
Copy Markdown
Contributor Author

@FabianLars can please explain what needs to be done for the {{}}? Is it for the dynamic URL? What exactly is missing and how it should work?

I will also take a look at latest.json generation.

@FabianLars

FabianLars commented Aug 26, 2025

Copy link
Copy Markdown
Member

it's for the dynamic urls, yes and i'm pretty sure that it would require really just #2624 (comment) and #2624 (comment)

edit: nevermind, with some of the changes since then those suggestions don't work as-is anymore but the gist is the same.

@kandrelczyk

Copy link
Copy Markdown
Contributor Author

Ok, I'm happy to do it. I can work on it this week.

@FabianLars

Copy link
Copy Markdown
Member

went ahead and opened #2960 sorry 😅 wanted to get to testing asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants