feat(websocket): add ability to remove listener

[twlite]

This pr changes listeners array to use a set instead, which prevents addition of duplicated listeners which could possibly lead to memory leaks.

[github-actions]

Package Changes Through 5d6a22c

There are 2 changes which include websocket-js with minor, websocket with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package	current	next
websocket	2.2.1	2.3.0
websocket-js	2.2.1	2.3.0

Add another change file through the GitHub UI by following this link.

---

Read about change files or the docs at github.com/jbolda/covector

[FabianLars]

i agree that a way to remove listeners is needed (that's why i didn't close the issue) but i'm not a fan of the Set here (or how it was used). I can very much imagine that someone wants to register the same function twice for whatever reason. Buuuut i'm totally fine with doing it this way and waiting to see if anyone actually complains.

Also, changing the return value is technically a breaking change but because it didn't return anything before and because this plugin doesn't have that many users i think we can get away with it.

[twlite]

Also, changing the return value is technically a breaking change but because it didn't return anything before and because this plugin doesn't have that many users i think we can get away with it.

Yes, that's exactly what I thought 😅

i'm not a fan of the Set here (or how it was used). I can very much imagine that someone wants to register the same function twice for whatever reason.

Yeah but it doesn't make sense to do so because same function gets invoked multiple times which can cause weird behaviors.

[jffaust]

The ability to remove a listener is pretty important in my opinion. Otherwise, you'd have to close the socket but you might still need the connection for other purposes. I say let's proceed with these changes.

@twlite do you think you can look at the merge conflicts?

[twlite]

@twlite do you think you can look at the merge conflicts?

done

[twlite]

Looks like we got an error saying Missing "minor" bump for Rust package "websocket" in .changes/cleanup-fn-websocket.md.. I have not touched the rust part here, do I still have to add it?

[FabianLars]

yes. since 2.2.0 the rust and js package must have matching versions (added the workflow at the same time to train ourselves to remember that)

[jffaust]

Are we good to go @FabianLars ? I looked around the documentation but I couldn't find any details about the release schedule/mechanism. Will merging this PR automatically create a new version of the package on NPM?