feat(shell) add wait fn to get event from child process #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugins/shell/src/commands.rs
Outdated
| @@ -302,6 +303,20 @@ pub fn kill<R: Runtime>( | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[tauri::command] | |||
| pub fn wait<R: Runtime>( | |||
There was a problem hiding this comment.
It will block the whole app to wait for the process
There was a problem hiding this comment.
I use async to avoid blocking thread
plugins/shell/src/process/mod.rs
Outdated
| @@ -84,6 +84,12 @@ impl CommandChild { | |||
| pub fn pid(&self) -> u32 { | |||
| self.inner.id() | |||
| } | |||
|
|
|||
| /// Waits for the child to exit completely, returning the status that it exited with. | |||
| pub fn wait(self) -> crate::Result<std::process::ExitStatus> { | |||
There was a problem hiding this comment.
It will block the whole app to wait for the process to exit, we need to use something async / non blocking
There was a problem hiding this comment.
async fn will also block it
| @@ -302,6 +302,19 @@ pub fn kill<R: Runtime>( | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[tauri::command] | |||
There was a problem hiding this comment.
Use try_wait and if it's ready then wait for the response
| @@ -84,6 +84,14 @@ impl CommandChild { | |||
| pub fn pid(&self) -> u32 { | |||
| self.inner.id() | |||
| } | |||
|
|
|||
| /// Waits for the child to exit completely, returning the status that it exited with. | |||
| pub async fn wait(self) -> crate::Result<ExitStatus> { | |||
There was a problem hiding this comment.
|
Also, you may use tokio::process https://docs.rs/tokio/latest/tokio/process/struct.Command.html instead of std::process |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1920