refactor(apple): fix bundle version validation - #450
Merged
Conversation
bundle version can actually contain one to three period-separated integers, so our validation is incorrect see https://developer.apple.com/documentation/bundleresources/information-property-list/cfbundleversion
Contributor
Package Changes Through 236b026There are 1 changes which include cargo-mobile2 with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Merged
lucasfernog
added a commit
to tauri-apps/tauri
that referenced
this pull request
Apr 12, 2025
follow-up for #13030 and tauri-apps/cargo-mobile2#450 the bundle version validation has been updated, now it can actually handle one or two integers (e.g. `100` or `10.7`) instead of just full triple semver strings (e.g. `10.7.1`).
lucasfernog
added a commit
to tauri-apps/tauri
that referenced
this pull request
Apr 12, 2025
* feat(cli): enhance iOS bundle version formatting follow-up for #13030 and tauri-apps/cargo-mobile2#450 the bundle version validation has been updated, now it can actually handle one or two integers (e.g. `100` or `10.7`) instead of just full triple semver strings (e.g. `10.7.1`). * lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bundle version can actually contain one to three period-separated integers, so our validation is incorrect
see https://developer.apple.com/documentation/bundleresources/information-property-list/cfbundleversion