Use static functions

tattali · Jan 16, 2024 · 3e7a6cd · 3e7a6cd
1 parent 7f40039
commit 3e7a6cd
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/.php-cs-fixer.dist.php b/.php-cs-fixer.dist.php
@@ -24,10 +24,6 @@
         'array_syntax' => [
             'syntax' => 'short',
         ],
-        'braces' => [
-            'allow_single_line_closure' => true,
-        ],
-        'compact_nullable_typehint' => true,
         'doctrine_annotation_array_assignment' => [
             'operator' => '=',
         ],

diff --git a/src/EventListener/RequestResponseListener.php b/src/EventListener/RequestResponseListener.php
@@ -272,7 +272,7 @@ protected function getRedirectResponse(Request $request, string $view): ?Redirec
      */
     protected function prepareResponseModification(string $view): void
     {
-        $this->modifyResponseClosure = function (DeviceView $deviceView, ResponseEvent $event) use ($view) {
+        $this->modifyResponseClosure = static function (DeviceView $deviceView, ResponseEvent $event) use ($view) {
             return $deviceView->modifyResponse($view, $event->getResponse());
         };
     }

diff --git a/tests/DataCollector/DeviceDataCollectorTest.php b/tests/DataCollector/DeviceDataCollectorTest.php
@@ -114,12 +114,12 @@ public function testCollectCurrentViewMobileCanUseTablet(): void
         $this->request->expects(self::any())->method('getBaseUrl')->willReturn('/base-url');
         $this->request->expects(self::any())->method('getPathInfo')->willReturn('/path-info');
         $test = $this;
-        $this->request->expects(self::any())->method('getQueryString')->willReturnCallback(function () use ($test) {
+        $this->request->expects(self::any())->method('getQueryString')->willReturnCallback(static function () use ($test) {
             $qs = Request::normalizeQueryString($test->request->server->get('QUERY_STRING'));
 
             return '' === $qs ? null : $qs;
         });
-        $this->request->expects(self::any())->method('getUri')->willReturnCallback(function () use ($test) {
+        $this->request->expects(self::any())->method('getUri')->willReturnCallback(static function () use ($test) {
             if (null !== $qs = $test->request->getQueryString()) {
                 $qs = '?'.$qs;
             }
@@ -177,12 +177,12 @@ public function testCollectCurrentViewFullCanUseMobile(): void
         $this->request->expects(self::any())->method('getBaseUrl')->willReturn('/base-url');
         $this->request->expects(self::any())->method('getPathInfo')->willReturn('/path-info');
         $test = $this;
-        $this->request->expects(self::any())->method('getQueryString')->willReturnCallback(function () use ($test) {
+        $this->request->expects(self::any())->method('getQueryString')->willReturnCallback(static function () use ($test) {
             $qs = Request::normalizeQueryString($test->request->server->get('QUERY_STRING'));
 
             return '' === $qs ? null : $qs;
         });
-        $this->request->expects(self::any())->method('getUri')->willReturnCallback(function () use ($test) {
+        $this->request->expects(self::any())->method('getUri')->willReturnCallback(static function () use ($test) {
             if (null !== $qs = $test->request->getQueryString()) {
                 $qs = '?'.$qs;
             }
@@ -240,12 +240,12 @@ public function testCollectCurrentViewFullCantUseMobile(): void
         $this->request->expects(self::any())->method('getBaseUrl')->willReturn('/base-url');
         $this->request->expects(self::any())->method('getPathInfo')->willReturn('/path-info');
         $test = $this;
-        $this->request->expects(self::any())->method('getQueryString')->willReturnCallback(function () use ($test) {
+        $this->request->expects(self::any())->method('getQueryString')->willReturnCallback(static function () use ($test) {
             $qs = Request::normalizeQueryString($test->request->server->get('QUERY_STRING'));
 
             return '' === $qs ? null : $qs;
         });
-        $this->request->expects(self::any())->method('getUri')->willReturnCallback(function () use ($test) {
+        $this->request->expects(self::any())->method('getUri')->willReturnCallback(static function () use ($test) {
             if (null !== $qs = $test->request->getQueryString()) {
                 $qs = '?'.$qs;
             }