[RFC][WIP] ebpf/PSA: Checksum support for fields wider than 64 bits #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osinstom
approved these changes
Dec 20, 2022
This PR improves support for fields wider than 64 bits. This is done mostly by fixing bugs and some refactors. The assumption for fields wider than 64 bits is that byte order of them is network byte order, which means that byte order is preserved during parser or deparser. To achieve initial support for wide fields, the following changes has been made: - Fixed byte order of bytes emitted in deparser. Parser had proper implementation of this. - Allow to assign one field to another. - Improved code for generating table key during lookup. `exact`, `lpm` or `ternary` match type can used. - Improved generation of table const entries (now mostly using Visitors). - Improved prefix length calculation for LPM table. The current PR allows to parse, deparse, match in tables and assign wide fields. Subsequent PR(s) will extend wide fields support for externs.
tatry
force-pushed
the
tatry/wide-fields-table
branch
from
1de3623
to
0cbde36
Compare
This commit adds support for fields wider than 64 bits in implemented checksum algorithms.
tatry
force-pushed
the
tatry/wide-fields-checksum
branch
from
30eacfc
to
81f26bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for fields wider than 64 bits in implemented checksum algorithms.