Ember: Upgrade through 43 minor versions, 2 majors, and 2 paradigm shifts

examples/emberjs/README.md

@@ -1,36 +1,26 @@
-# Ember.js TodoMVC Example using Ember CLI v3.2
+# Ember.js TodoMVC Example using Ember 5.3
 
 > A framework for creating ambitious web applications.
 
 > _[Ember.js - emberjs.com](http://emberjs.com)_
-> _[Ember CLI - ember-cli.com](http://ember-cli.com)_
+
+\*Ember is not an MVC framework.
 
 ## Note for people updating this app.
 
 The `index.html` and the `assets` folder in the parent folder as simlinks into the items with the same names inside `dist`. The `dist` folder has to be checked in git and built for production.
 
-You can develop this project as a standard Ember CLI application:
-
-```bash
-$ cd todomvc
-$ npm install
-$ ember server
-```
-
-Update to the latest Ember with `ember-cli-update` and with the latest codemods:
+You can develop this project as a standard Ember application:
 
 ```bash
 $ cd todomvc
-$ npx ember-cli-update
-$ git commit -m 'Update Ember with ember-cli-update' -a
-$ npx ember-cli-update --run-codemods
-$ git commit -m 'Update TodoMVC with codemods' -a
+$ pnpm install
+$ pnpm start
 ```
-
 Build Ember TodoMVC for production:
 
 ```bash
-$ ember build --prod
+$ pnpm build 
 ```
 
 Run Cypress Test:

examples/emberjs/todomvc/.editorconfig

@@ -4,7 +4,6 @@
 
 root = true
 
-
 [*]
 end_of_line = lf
 charset = utf-8

examples/emberjs/todomvc/.ember-cli

@@ -5,5 +5,11 @@
 
     Setting `disableAnalytics` to true will prevent any data from being sent.
   */
-  "disableAnalytics": false
+  "disableAnalytics": false,
+
+  /**
+    Setting `isTypeScriptProject` to true will force the blueprint generators to generate TypeScript
+    rather than JavaScript by default, when a TypeScript version of a given blueprint is available.
+  */
+  "isTypeScriptProject": false
 }

examples/emberjs/todomvc/.eslintignore

@@ -1,18 +1,13 @@
 # unconventional js
 /blueprints/*/files/
-/vendor/
 
 # compiled output
 /dist/
-/tmp/
-
-# dependencies
-/bower_components/
 
 # misc
 /coverage/
+!.*
+.*/
 
 # ember-try
 /.node_modules.ember-try/
-/bower.json.ember-try
-/package.json.ember-try

examples/emberjs/todomvc/.eslintrc.cjs

@@ -0,0 +1,53 @@
+'use strict';
+
+/**
+ * ESLint is really complicated right now, so all of it is abstracted away.
+ * Updates coming soon (and hopefully to the built-in ember experience).
+ */
+const { configs } = require('@nullvoxpopuli/eslint-configs');
+
+const config = configs.ember();
+
+const hasTS = (globArray) => globArray.some((glob) => glob.includes('ts'));
+
+// Setup newer TS-aware lints
+function addTSProject(override) {
+	if (!hasTS(override.files)) return override;
+
+	return {
+		...override,
+		/**
+    * This is how you tell @typescript-eslint to use your tsconfig.
+    * However, for gts files, we get this:
+    *
+       <repo>/app/components/welcome.gts
+         0:0  error  Parsing error: ESLint was configured to run on
+              `<tsconfigRootDir>/app/components/welcome.gts/0_<repo>/app/components/welcome.gts/0_<repo>/app/components/welcome.gts/0_<repo>/app/components/welcome.gts`
+              using `parserOptions.project`: <tsconfigRootDir>/tsconfig.json
+       However, that TSConfig does not include this file. Either:
+       - Change ESLint's list of included files to not include this file
+       - Change that TSConfig to include this file
+       - Create a new TSConfig that includes this file and include it in your parserOptions.project
+
+      This is likely because we need to configure the TS parser to use glint instead of tsc
+    */
+		// parserOptions: {
+		//   ...override.parserOptions,
+		//   extraFileExtensions: [".gts"],
+		//   project: path.join(__dirname, "./tsconfig.json"),
+		//   // TODO: try to set the Glint Program
+		//   //   https://typescript-eslint.io/packages/parser/
+		//   // program: import("@glint/core"),
+		// },
+		rules: {
+			...override.rules,
+			// Disabled until the above issue is resolved
+			'@typescript-eslint/prefer-optional-chain': 'off',
+		},
+	};
+}
+
+module.exports = {
+	...config,
+	overrides: [...config.overrides].map(addTSProject),
+};

examples/emberjs/todomvc/.gitignore

@@ -1,23 +1,22 @@
-# See https://help.github.com/ignore-files/ for more about ignoring files.
-
-# compiled output
-# /dist/
-/tmp/
 
 # dependencies
-/bower_components/
 /node_modules/
 
 # misc
-/.sass-cache
-/connect.lock
+/.env*
+/.pnp*
+/.eslintcache
 /coverage/
-/libpeerconnection.log
 /npm-debug.log*
 /testem.log
 /yarn-error.log
 
 # ember-try
 /.node_modules.ember-try/
-/bower.json.ember-try
+/npm-shrinkwrap.json.ember-try
 /package.json.ember-try
+/package-lock.json.ember-try
+/yarn.lock.ember-try
+
+# broccoli-debug
+/DEBUG/

examples/emberjs/todomvc/.npmrc

@@ -0,0 +1,9 @@
+# best for apps, not for libraries
+resolution-mode=highest
+
+# ok for apps, disaster for libraries
+auto-install-peers=true
+
+# for cloudflare... but also because not all dependencies of the ecosystem have gotten strict yet
+# TODO: set this to true
+strict-peer-dependencies=false

examples/emberjs/todomvc/.prettierignore

@@ -0,0 +1,19 @@
+# unconventional js
+/blueprints/*/files/
+
+# compiled output
+/dist/
+
+# misc
+/coverage/
+!.*
+.*/
+README.md
+
+# ember-try
+/.node_modules.ember-try/
+
+# everything else
+*.yaml
+.git/
+.github/

examples/emberjs/todomvc/.prettierrc.js

@@ -0,0 +1,23 @@
+'use strict';
+
+module.exports = {
+	useTabs: true,
+	singleQuote: true,
+	printWidth: 100,
+	plugins: ['prettier-plugin-ember-template-tag'],
+	overrides: [
+		{
+			files: ['**/*.hbs'],
+			options: {
+				singleQuote: false,
+			},
+		},
+		{
+			files: ['**/*.gjs', '**/*.gts'],
+			plugins: ['prettier-plugin-ember-template-tag'],
+			options: {
+				templateSingleQuote: false,
+			},
+		},
+	],
+};

examples/emberjs/todomvc/.stylelintignore

@@ -0,0 +1,8 @@
+# unconventional files
+/blueprints/*/files/
+
+# compiled output
+/dist/
+
+# addons
+/.node_modules.ember-try/

examples/emberjs/todomvc/.stylelintrc.js

@@ -0,0 +1,5 @@
+'use strict';
+
+module.exports = {
+	extends: ['stylelint-config-standard', 'stylelint-prettier/recommended'],
+};

examples/emberjs/todomvc/.template-lintrc.js

@@ -1,5 +1,12 @@
 'use strict';
 
 module.exports = {
-  extends: 'recommended'
+	extends: 'recommended',
+	rules: {
+		// Polaris allows <style> tags
+		//   https://github.com/ember-template-lint/ember-template-lint/blob/master/lib/rules/no-forbidden-elements.js
+		'no-forbidden-elements': ['error', { forbidden: ['meta', 'html', 'script'] }],
+		// Stylistic
+		'no-inline-styles': false,
+	},
 };

examples/emberjs/todomvc/.vscode/extensions.json

@@ -0,0 +1,5 @@
+{
+  "recommendations": [
+    "embertooling.emberjs"
+  ]
+}

examples/emberjs/todomvc/.watchmanconfig

@@ -1,3 +1,3 @@
 {
-  "ignore_dirs": ["tmp", "dist"]
+	"ignore_dirs": ["dist"]
 }

examples/emberjs/todomvc/README.md

@@ -0,0 +1,53 @@
+# todomvc
+
+## Prerequisites
+
+You will need the following things properly installed on your computer.
+
+- [Git](https://git-scm.com/)
+- [Node.js](https://nodejs.org/) (with npm)
+- [Ember CLI](https://cli.emberjs.com/release/)
+- [Google Chrome](https://google.com/chrome/)
+
+## Installation
+
+- `git clone <repository-url>` this repository
+- `cd todomvc`
+- `pnpm install`
+
+## Running / Development
+
+- `ember serve`
+- Visit your app at [http://localhost:4200](http://localhost:4200).
+- Visit your tests at [http://localhost:4200/tests](http://localhost:4200/tests).
+
+### Code Generators
+
+Make use of the many generators for code, try `ember help generate` for more details
+
+### Running Tests
+
+- `ember test`
+- `ember test --server`
+
+### Linting
+
+- `pnpm run lint`
+- `pnpm lint:fix`
+
+### Building
+
+- `ember build` (development)
+- `ember build --environment production` (production)
+
+### Deploying
+
+Specify what it takes to deploy your app.
+
+## Further Reading / Useful Links
+
+- [ember.js](https://emberjs.com/)
+- [ember-cli](https://cli.emberjs.com/release/)
+- Development Browser Extensions
+  - [ember inspector for chrome](https://chrome.google.com/webstore/detail/ember-inspector/bmdblncegkenkacieihfhpjfppoconhi)
+  - [ember inspector for firefox](https://addons.mozilla.org/en-US/firefox/addon/ember-inspector/)