This repository has been archived by the owner on Sep 7, 2022. It is now read-only.
PropertyCross with V-Play Apps #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just wanted to follow up if there is anything missing in the pull request? Many thanks! |
|
Hi - sorry for the delay, just getting back to some PropertyCross pull requests. Is this one still good to go? |
|
Hi @ColinEberhardt, thanks for checking back. This should still be good to go if no changes were made to the project definition itself. Thanks! |
|
Great - thanks. |
|
Now that it's merged, we need to get it on the website. You can see a recent Pull Request for updating the site here: ColinEberhardt/PropertyCross-Site#28 Would you be OK to give this a try? |
|
Sure, I will keep you updated on this, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #323 here is the PR for the V-Play Apps implementation. Please let me know if any changes are required.
Many thanks,
Alex