Update jquery mobile #312
Update jquery mobile #312
Conversation
- Uses the default theme - Knockout also updated - Turned network callbacks to use JQuery promises - Unified Windows Phone 8, Android and iOS implmentations
Currently the margin is too small
|
Nice work - just tried this out and it works great :-) Probably just needs the README updating and then its ready to merge. |
| <!-- jquery mobile styling --> | ||
| <link rel="stylesheet" href="lib/jquery.mobile-1.4.5.min.css" /> | ||
| <!-- application specific styling --> | ||
| <link rel="stylesheet" type="text/css" href="style/style.css" /> |
|
Sorry for the nitpicks ;) nice work! |
Thanks @arthurvr - any additional reviews are welcome :-) |
|
@ColinEberhardt Are there any outstanding issues on this pull request? The README file has been cleaned up to reflect the changes made to the project (i.e. the move to using the default theme). |
|
One outstanding issue is the JQueryMobile assets, which are using an old JQueryMobile logo. Should this be fixed as par of this PR? It is worth noting, the website PR includes an update to the JQueryMobile logo (https://github.com/matthewdunsdon/PropertyCross-Site/commit/f5254b66b90a8a0e6609121650468be003989ed1) |
|
Great stuff - while you are working in this area, it would be great if you could update the logo too. I'll merge immediately after you do that. Thanks for contributing :-) |
Also updated titanium icon and asset generation scripts
|
Updated JQueryMobile icons
|
…-mobile Update jquery mobile
|
Awesome - thanks. I'll take a look at your 'site' PR next |
Relates to #310