Fix random bug where regex doesn’t match every reg. expression

[christophby]

Im my case it skipped random matches. This PR fixes it.

[scottmas]

I too faced this same annoying error and came upon the same fix, since RegExp.exec mutates the RegExp object

[scottmas]

In the meanwhile, while people are waiting for a fix, you can simply always ensure the pattern is a fresh instance in your render method.

const HASHTAG_REGEX = /#[a-z]+\b/i
...
{ pattern: new RegExp(HASHTAG_REGEX) }

[fbartho]

@christophby & @scottmas I'd be happy to ship this if the suggested change was made, and if we add tests that exercise this bug, so we make sure not to have a regression.

Please merge in master before you do that as I've switched the test harness to jest. 🥂

[fbartho]

Please apply:
https://github.com/taskrabbit/react-native-parsed-text/pull/47/files#r210374952

And please add tests!

[shramadani]

Please apply:
https://github.com/taskrabbit/react-native-parsed-text/pull/47/files#r210374952

And please add tests!

Just tried this change locally and seems to be working as expected. Is it possible to merge this PR please?

[fbartho]

@shramadani -- if you want to help contribute tests for this PR, I'm looking to ship a new release of this this week. Please let me know if you're interested!

[ouoru]

@fbartho any updates on this? 😃

[fbartho]

Since there are no current tests, I'm going to try to write some myself. Additionally, there was a comment that I requested get applied, and that was resolved (hidden) instead of applying it.

I probably will reset the regexp by setting .lastIndex = 0 before the while loop assuming that doesn't break things.

This means I'm probably not going to merge this PR as is. I hope you understand @christophby

[fbartho]

There is an alternative implementation in this commit: e8f140e

I will spin a beta build shortly

[fbartho]

[email protected] is now available on npm -- please let me know if you have any issues!

[fbartho]

Closing this PR as there would now be conflicts, but please report if you have any issues with the current implementation, or if further fixes are necessary!