Remove weekStartsMonday and weekStartsSunday and replace with weekStartsOn #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtsOn This change allows the work week to start on any day - this is 0-based starting with Sunday.
|
I'm definitely open to pulling this into mainline. If it's backwards compatible and does not have rough edges (like the week number issue) I'm all for it. |
|
This is definitely a back-burner task for me, but I'll try to get back to it relatively soon. Thanks! |
|
This seems like a good one, any news on an update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the work week to start on any day - this is 0-based starting with Sunday.
Not sure if this would be useful for anyone else, but I need to get my status in to my manager on Thursday so that they can get their status consolidated and up the management chain on time. This way I can view the project based on a Thursday week start.