Skip to content

Conversation

@vldmrdev
Copy link
Contributor

@vldmrdev vldmrdev commented Dec 1, 2025

Issue: #108

  • Remove poetry.lock and rewrite pyproject.toml in a way that compatible with PEP-621;

  • Change poetry run to uv run in pre-commit config;

  • Change CI/CD pipelines. They should use python versions from 3.10 to 3.13 and uv. You can find example of pipelines here. Don't forget to check that cache for dependencies in tests is enabled)

  • Check that there is no mentions of poetry in docs / readme files.

  • Please also replace old-style type annotations in repository code using this two ruff rules.

@danfimov danfimov self-requested a review December 1, 2025 09:13
@vldmrdev vldmrdev force-pushed the 108-remove-depricated-python-versions branch from fe9bf68 to ed0fb08 Compare December 1, 2025 09:37
@vldmrdev vldmrdev requested a review from danfimov December 1, 2025 09:55
Copy link
Member

@danfimov danfimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vldmrdev
Tests and linter checks are broken in CI. Please run pre-commit checks locally (pre-commit run -a) and tests to make sure that all works fine

@vldmrdev
Copy link
Contributor Author

vldmrdev commented Dec 1, 2025

@danfimov What maximum redis version can be used? I see mypy' issues in main branch too, for example:

taskiq_redis/list_schedule_source.py:202: error: Incompatible types in "await"
(actual type "Awaitable[list[Any]] | list[Any]", expected type "Awaitable[Any]")
 [misc]
                timed.extend(await redis.lrange(self._get_time_key(current...
                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~..

as I understand it is related to type return in redis.lrange and it's a redis "problem" and I can't use newer redis version, right? I am not sure how to fix it..

@danfimov
Copy link
Member

danfimov commented Dec 1, 2025

as I understand it is related to type return in redis.lrange and it's a redis "problem" and I can't use newer redis version, right? I am not sure how to fix it..

For now you can just add comment on line with issue - # type: ignore. I'll check that is going on with mypy there later.

@vldmrdev
Copy link
Contributor Author

vldmrdev commented Dec 2, 2025

For now you can just add comment on line with issue - # type: ignore

For every of the 23 mypy errors? Maybe it's possible to temporarily disable mypy tests? Or pause this PR.

FYI - redis/redis-py#2399

@danfimov
Copy link
Member

danfimov commented Dec 2, 2025

Maybe something like that will be useful:

[[tool.mypy.overrides]]
module = [
    "redis", "redis.*",
]
ignore_missing_imports = true

If not, let's just skip mypy tests/pre-commit checks. They seems to be broken before, and I will fix it in different issue. Really don't want to block this MR because of this problem)

@vldmrdev vldmrdev force-pushed the 108-remove-depricated-python-versions branch from 71eeaf8 to a9ed7d9 Compare December 3, 2025 11:36
@vldmrdev
Copy link
Contributor Author

vldmrdev commented Dec 3, 2025

@danfimov module = [ "redis", "redis.*",] - it doesnt' work 🤷‍♂️

@vldmrdev vldmrdev requested a review from danfimov December 4, 2025 03:44
@danfimov danfimov mentioned this pull request Dec 6, 2025
@danfimov danfimov force-pushed the 108-remove-depricated-python-versions branch from a9ed7d9 to a695ba2 Compare December 6, 2025 10:16
@danfimov danfimov force-pushed the 108-remove-depricated-python-versions branch from 87490a7 to 2c651a2 Compare December 6, 2025 10:21
@danfimov danfimov force-pushed the 108-remove-depricated-python-versions branch from f374530 to 4668ff2 Compare December 6, 2025 10:26
@danfimov danfimov merged commit d303934 into taskiq-python:main Dec 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants