-
Notifications
You must be signed in to change notification settings - Fork 28
Remove support for deprecated Python version and move to uv #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for deprecated Python version and move to uv #111
Conversation
fe9bf68 to
ed0fb08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vldmrdev
Tests and linter checks are broken in CI. Please run pre-commit checks locally (pre-commit run -a) and tests to make sure that all works fine
|
@danfimov What maximum redis version can be used? I see mypy' issues in main branch too, for example: as I understand it is related to type return in redis.lrange and it's a redis "problem" and I can't use newer redis version, right? I am not sure how to fix it.. |
For now you can just add comment on line with issue - |
For every of the 23 mypy errors? Maybe it's possible to temporarily disable mypy tests? Or pause this PR. FYI - redis/redis-py#2399 |
|
Maybe something like that will be useful: If not, let's just skip mypy tests/pre-commit checks. They seems to be broken before, and I will fix it in different issue. Really don't want to block this MR because of this problem) |
71eeaf8 to
a9ed7d9
Compare
|
@danfimov |
a9ed7d9 to
a695ba2
Compare
87490a7 to
2c651a2
Compare
f374530 to
4668ff2
Compare
Issue: #108
Remove poetry.lock and rewrite pyproject.toml in a way that compatible with PEP-621;
Change poetry run to uv run in pre-commit config;
Change CI/CD pipelines. They should use python versions from 3.10 to 3.13 and uv. You can find example of pipelines here. Don't forget to check that cache for dependencies in tests is enabled)
Check that there is no mentions of poetry in docs / readme files.
Please also replace old-style type annotations in repository code using this two ruff rules.