fix: get_ancestors should ignore 404s #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen when attempting to fetch tasks (either directly or indirectly) that have expired. My view on this is that such tasks should be treated as no longer being dependencies since they no longer exist. I can see a case for maybe making this optional behaviour, but I don't know of any use cases where we'd want to raise an exception for this case. Certainly when being used as part of actions or other CI code it ends up being a ticking time bomb.
hneiva
approved these changes
Sep 3, 2024
ahal
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Makes sense to me, I'm surprised we haven't hit this before now.
We could return a tuple with expired_ancestors being the second variable.. But it's probably not worth the breaking change. Also it wouldn't even be fully accurate as we'd have no way of finding dependencies of the expired tasks in turn.
bhearsum
added a commit
to bhearsum/firefox-translations-training
that referenced
this pull request
Sep 5, 2024
This includes taskcluster/taskgraph#569, which is the upstreamed version of the fix for taskcluster/taskgraph#569.
bhearsum
added a commit
to bhearsum/firefox-translations-training
that referenced
this pull request
Sep 5, 2024
This includes taskcluster/taskgraph#569, which is the upstreamed version of the fix for taskcluster/taskgraph#569.
bhearsum
added a commit
to bhearsum/firefox-translations-training
that referenced
this pull request
Sep 5, 2024
This includes taskcluster/taskgraph#569, which is the upstreamed version of the fix for taskcluster/taskgraph#569.
bhearsum
added a commit
to mozilla/translations
that referenced
this pull request
Sep 6, 2024
This includes taskcluster/taskgraph#569, which is the upstreamed version of the fix for taskcluster/taskgraph#569.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen when attempting to fetch tasks (either directly or indirectly) that have expired. My view on this is that such tasks should be treated as no longer being dependencies since they no longer exist.
I can see a case for maybe making this optional behaviour, but I don't know of any use cases where we'd want to raise an exception for this case. Certainly when being used as part of actions or other CI code it ends up being a ticking time bomb.