Bug 1502337: Initial support for docker-worker payloads

This commit implements the initial support for docker-worker payloads. So far, only the Image, Command, Env and MaxRunTime fields are supported. It hasn't been extensive tested so features like task cancellation may not work. Also, it doesn't implement custom artifacts and more extensive tests. The support for docker-worker payloads is achieved through build flags. To build with docker-worker paylod, build it with the "docker" flag, like so: $ go build -tags=docker Notice that generic-worker will not be supported in this build. We also needed to upgrade golang due to a bug in the go compiler [1]. [1] golang/go#25908
taskcluster · Nov 7, 2018 · dae6d63 · dae6d63
1 parent 1d86e58
commit dae6d63
Show file tree

Hide file tree

Showing 43 changed files with 1,496 additions and 305 deletions.
diff --git a/.gitignore b/.gitignore
@@ -47,3 +47,6 @@ directory-caches.json
 file-caches.json
 tasks-resolved-count.txt
 /revision.txt
+
+# binary file
+generic-worker
diff --git a/.taskcluster.yml b/.taskcluster.yml
@@ -70,8 +70,8 @@ tasks:
       maxRunTime: 3600
       command:
         - set CGO_ENABLED=0
-        - set GOPATH=%CD%\gopath1.10.3
-        - set GOROOT=%CD%\go1.10.3\go
+        - set GOPATH=%CD%\gopath1.10.4
+        - set GOROOT=%CD%\go1.10.4\go
         - set PATH=%CD%\git\cmd;%GOPATH%\bin;%GOROOT%\bin;%PATH%
         - git config --global core.autocrlf false
         - go version
@@ -111,16 +111,16 @@ tasks:
         - ineffassign .
       artifacts:
         - name: public/build/generic-worker-windows-amd64.exe
-          path: gopath1.10.3\bin\generic-worker.exe
+          path: gopath1.10.4\bin\generic-worker.exe
           expires: "{{ '2 weeks' | $fromNow }}"
           type: file
       mounts:
         - cacheName: generic-worker-checkout
-          directory: gopath1.10.3\src
+          directory: gopath1.10.4\src
         - content:
-            url: https://storage.googleapis.com/golang/go1.10.3.windows-amd64.zip
-            sha256: a3f19d4fc0f4b45836b349503e347e64e31ab830dedac2fc9c390836d4418edb
-          directory: go1.10.3
+            url: https://storage.googleapis.com/golang/go1.10.4.windows-amd64.zip
+            sha256: 5499aa98399664df8dc1da5c3aaaed14b3130b79c713b5677a0ee9e93854476c
+          directory: go1.10.4
           format: zip
         - content:
             url: https://github.com/git-for-windows/git/releases/download/v2.14.1.windows.1/MinGit-2.14.1-64-bit.zip
@@ -152,8 +152,8 @@ tasks:
       maxRunTime: 3600
       command:
         - set CGO_ENABLED=0
-        - set GOPATH=%CD%\gopath1.10.3
-        - set GOROOT=%CD%\go1.10.3\go
+        - set GOPATH=%CD%\gopath1.10.4
+        - set GOROOT=%CD%\go1.10.4\go
         - set PATH=%CD%\git\bin;%GOPATH%\bin;%GOROOT%\bin;%PATH%
         - git config --global core.autocrlf false
         - go version
@@ -182,16 +182,16 @@ tasks:
         - ineffassign .
       artifacts:
         - name: public/build/generic-worker-windows-386.exe
-          path: gopath1.10.3\bin\generic-worker.exe
+          path: gopath1.10.4\bin\generic-worker.exe
           expires: "{{ '2 weeks' | $fromNow }}"
           type: file
       mounts:
         - cacheName: generic-worker-checkout
-          directory: gopath1.10.3\src
+          directory: gopath1.10.4\src
         - content:
-            url: https://storage.googleapis.com/golang/go1.10.3.windows-386.zip
-            sha256: 89696a29bdf808fa9861216a21824ae8eb2e750a54b1424ce7f2a177e5cd1466
-          directory: go1.10.3
+            url: https://storage.googleapis.com/golang/go1.10.4.windows-386.zip
+            sha256: 407e5619048c427de4a65b26edb17d54c220f8c30ebd358961b1785a38394ec9
+          directory: go1.10.4
           format: zip
         - content:
             url: https://github.com/git-for-windows/git/releases/download/v2.11.0.windows.3/Git-2.11.0.3-32-bit.tar.bz2
@@ -223,8 +223,8 @@ tasks:
       maxRunTime: 3600
       command:
         - set CGO_ENABLED=0
-        - set GOPATH=%CD%\gopath1.10.3
-        - set GOROOT=%CD%\go1.10.3\go
+        - set GOPATH=%CD%\gopath1.10.4
+        - set GOROOT=%CD%\go1.10.4\go
         - set PATH=%CD%\git\cmd;%GOPATH%\bin;%GOROOT%\bin;%PATH%
         - git config --global core.autocrlf false
         - go version
@@ -264,16 +264,16 @@ tasks:
         - ineffassign .
       artifacts:
         - name: public/build/generic-worker-windows-amd64.exe
-          path: gopath1.10.3\bin\generic-worker.exe
+          path: gopath1.10.4\bin\generic-worker.exe
           expires: "{{ '2 weeks' | $fromNow }}"
           type: file
       mounts:
         - cacheName: generic-worker-checkout
-          directory: gopath1.10.3\src
+          directory: gopath1.10.4\src
         - content:
-            url: https://storage.googleapis.com/golang/go1.10.3.windows-amd64.zip
-            sha256: a3f19d4fc0f4b45836b349503e347e64e31ab830dedac2fc9c390836d4418edb
-          directory: go1.10.3
+            url: https://storage.googleapis.com/golang/go1.10.4.windows-amd64.zip
+            sha256: 5499aa98399664df8dc1da5c3aaaed14b3130b79c713b5677a0ee9e93854476c
+          directory: go1.10.4
           format: zip
         - content:
             url: https://github.com/git-for-windows/git/releases/download/v2.14.1.windows.1/MinGit-2.14.1-64-bit.zip
@@ -308,8 +308,8 @@ tasks:
           - -vxec
           - |
             export CGO_ENABLED=0
-            export GOROOT="$(pwd)/go1.10.3/go"
-            export GOPATH="$(pwd)/gopath1.10.3"
+            export GOROOT="$(pwd)/go1.10.4/go"
+            export GOPATH="$(pwd)/gopath1.10.4"
             export PATH="${GOPATH}/bin:${GOROOT}/bin:${PATH}"
             go version
             go env
@@ -335,16 +335,16 @@ tasks:
             ineffassign .
       artifacts:
         - name: public/build/generic-worker-darwin-amd64
-          path: gopath1.10.3/bin/generic-worker
+          path: gopath1.10.4/bin/generic-worker
           expires: "{{ '2 weeks' | $fromNow }}"
           type: file
       mounts:
         - cacheName: generic-worker-checkout
-          directory: gopath1.10.3/src
+          directory: gopath1.10.4/src
         - content:
-            url: https://storage.googleapis.com/golang/go1.10.3.darwin-amd64.tar.gz
-            sha256: 131fd430350a3134d352ee75c5ca456cdf4443e492d0527a9651c7c04e2b458d
-          directory: go1.10.3
+            url: https://storage.googleapis.com/golang/go1.10.4.darwin-amd64.tar.gz
+            sha256: 2ba324f01de2b2ece0376f6d696570a4c5c13db67d00aadfd612adc56feff587
+          directory: go1.10.4
           format: tar.gz
 
 
@@ -380,8 +380,8 @@ tasks:
   #         - -vxec
   #         - |
   #           export CGO_ENABLED=0
-  #           export GOROOT="$(pwd)/go1.10.3/go"
-  #           export GOPATH="$(pwd)/gopath1.10.3"
+  #           export GOROOT="$(pwd)/go1.10.4/go"
+  #           export GOPATH="$(pwd)/gopath1.10.4"
   #           export PATH="${GOPATH}/bin:${GOROOT}/bin:${PATH}"
   #           export CGO_ENABLED=0
   #           go version
@@ -407,16 +407,16 @@ tasks:
   #           ineffassign .
   #     artifacts:
   #       - name: public/build/generic-worker-linux-armv6l
-  #         path: gopath1.10.3/bin/generic-worker
+  #         path: gopath1.10.4/bin/generic-worker
   #         expires: "{{ '2 weeks' | $fromNow }}"
   #         type: file
   #     mounts:
   #       - cacheName: generic-worker-checkout
-  #         directory: gopath1.10.3/src
+  #         directory: gopath1.10.4/src
   #       - content:
-  #           url: https://storage.googleapis.com/golang/go1.10.3.linux-armv6l.tar.gz
+  #           url: https://storage.googleapis.com/golang/go1.10.4.linux-armv6l.tar.gz
   #           sha256: d3df3fa3d153e81041af24f31a82f86a21cb7b92c1b5552fb621bad0320f06b6
-  #         directory: go1.10.3
+  #         directory: go1.10.4
   #         format: tar.gz
 
 
@@ -472,13 +472,13 @@ tasks:
           "${GOPATH}/bin/ineffassign" .
       artifacts:
         - name: public/build/generic-worker-linux-amd64
-          path: gopath1.10.1/bin/generic-worker
+          path: gopath1.10.4/bin/generic-worker
           expires: "{{ '2 weeks' | $fromNow }}"
           type: file
       mounts:
         - cacheName: generic-worker-checkout
-          directory: gopath1.10.1/src
+          directory: gopath1.10.4/src
         - content:
-            url: https://storage.googleapis.com/golang/go1.10.1.linux-amd64.tar.gz
-          directory: go1.10.1
+            url: https://storage.googleapis.com/golang/go1.10.4.linux-amd64.tar.gz
+          directory: go1.10.4
           format: tar.gz
diff --git a/.travis.yml b/.travis.yml
@@ -1,6 +1,6 @@
 language: go
 go:
-  - "1.10.3"
+  - "1.10.4"
 
 env:
   - "CGO_ENABLED=0 GIMME_OS=linux GIMME_ARCH=386"

diff --git a/artifacts_test.go b/artifacts_test.go
@@ -1,3 +1,5 @@
+// +build !docker
+
 package main
 
 import (
@@ -13,17 +15,10 @@ import (
 	"golang.org/x/crypto/openpgp"
 	"golang.org/x/crypto/openpgp/clearsign"
 
-	"github.com/taskcluster/slugid-go/slugid"
 	tcclient "github.com/taskcluster/taskcluster-client-go"
 	"github.com/taskcluster/taskcluster-client-go/tcqueue"
 )
 
-var (
-	// all tests can share taskGroupId so we can view all test tasks in same
-	// graph later for troubleshooting
-	taskGroupID = slugid.Nice()
-)
-
 func validateArtifacts(
 	t *testing.T,
 	payloadArtifacts []Artifact,

diff --git a/aws_test.go b/aws_test.go
@@ -1,3 +1,5 @@
+// +build !docker
+
 package main
 
 import (

diff --git a/chain_of_trust_all-unix-style.go b/chain_of_trust_all-unix-style.go
@@ -1,4 +1,4 @@
-// +build !windows
+// +build !windows,!docker
 
 package main
 

diff --git a/chain_of_trust_docker.go b/chain_of_trust_docker.go
@@ -0,0 +1,11 @@
+// +build docker
+
+package main
+
+func (cot *ChainOfTrustTaskFeature) ensureTaskUserCantReadPrivateCotKey() error {
+	return nil
+}
+
+func secureSigningKey() error {
+	return nil
+}
diff --git a/docker_linux.go b/docker_linux.go