fix: binary data transmission (socketio#76)

taskade · Jun 11, 2020 · 334acae · 334acae
1 parent 51cf563
commit 334acae
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -7,6 +7,7 @@ var client = require('redis').createClient;
 var parser = require('socket.io-parser');
 var msgpack = require('notepack.io');
 var debug = require('debug')('socket.io-emitter');
+var hasBin = require('has-binary2');
 
 /**
  * Module exports.
@@ -123,7 +124,7 @@ Emitter.prototype.of = function(nsp){
 Emitter.prototype.emit = function(){
   // packet
   var args = Array.prototype.slice.call(arguments);
-  var packet = { type: parser.EVENT, data: args, nsp: this.nsp };
+  var packet = { type: hasBin(args) ? parser.BINARY_EVENT : parser.EVENT, data: args, nsp: this.nsp };
 
   var opts = {
     rooms: this._rooms,

diff --git a/package.json b/package.json
@@ -15,6 +15,7 @@
   },
   "dependencies": {
     "debug": "~3.1.0",
+    "has-binary2": "^2.0.0",
     "notepack.io": "~2.1.0",
     "redis": "2.6.3",
     "socket.io-parser": "3.1.2"