mf fixing #1
Merged
mf fixing #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation update to include the ALLOW_DUPLICATE_FIELD information (#71 ) Create docstring for ALLOW_DUPLICATE_FIELD and compile it into the API reference page. Includes example of how to use field and information on the getting started page about its purpose. Fix small issue with ALLOW_DUPLICATE_FIELD test that referenced by wrong name. Also updated the API reference to show the ALLOW_DUPLICATE_FIELD docstring in addition to it being displayed in the table of contents for the reading section. Update references to True/False & ALLOW_DUPLICATE_FIELD so Sphinx appropriately links to these items. Also found a small mistake in the tests that was missed originally I decided to fix here. Wasn't worth the extra effort of a separate PR.
1. Fixed byte_skip -1 reading to work on compressed data (issue #70) 2. Add error checking for line_skip and byte_skip < -1 3. Added tests for error checking and byte_skip functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.