Tests #32

BlitzKraft · 2016-07-07T17:54:44Z

Still a work in progress. Wrote two tests and they check out.

These are the TODOs I can think of. Feels like there should be more tests.

TODO:

Remove downloaded files after testing (clean up)
Test for comic out of range (or does not exist)

Download continues, if the comic is listed in the exclude list.

* Description contains alt text too. * index on master: 7b31df1 Description contains alt text too. * Now download-all works, with the alt-text. * Fails if it does not find an image. Examples: 1350, 1663 * Updated readme. * Updated readme. * Added exclude list to not stumble on comics without images. * my bad. * Updated readme. * Exclude list for image downloads. * Added 1350 to exclude. * Fixed conflicts from exclude list. * Fixed conflicts. * Hard coded description for 472. For the sake of completion. * Removed all comments. Except where non-trivial info is needed. * Used to cli.py with all the comments. Contains all the comments. Functionally identical.

Changelog ======== - fixed bug which stopped download of comic when there was no image. - fixed bug which did not download meta data for comic. - Added logo for the package - major refactoring - several bug fixes

Updating my fork of the repo.

* Description contains alt text too. * index on master: 7b31df1 Description contains alt text too. * Now download-all works, with the alt-text. * Fails if it does not find an image. Examples: 1350, 1663 * Updated readme. * Updated readme. * Added exclude list to not stumble on comics without images. * my bad. * Updated readme. * Exclude list for image downloads. * Added 1350 to exclude. * Fixed conflicts from exclude list. * Fixed conflicts. * Merged cleanUp. * Merged trimFat * Argparse. And short hand for options. * Check on refactoring. * No more docopts. closes tasdikrahman#10

Updating my fork of the repo.

* Description contains alt text too. * index on master: 7b31df1 Description contains alt text too. * Now download-all works, with the alt-text. * Fails if it does not find an image. Examples: 1350, 1663 * Updated readme. * Updated readme. * Added exclude list to not stumble on comics without images. * my bad. * Updated readme. * Exclude list for image downloads. * Added 1350 to exclude. * Fixed conflicts from exclude list. * Fixed conflicts. * Merged cleanUp. * Merged trimFat * Argparse. And short hand for options. * Check on refactoring. * No more docopts. * Show comic using feh. * Test files removed. * Uses xdg-open to show comics. * Updated README with new show option. Needs gif. Closes issue tasdikrahman#27

Updating my fork of the repo.

…nt double/single qoute usage.

* Description contains alt text too. * index on master: 7b31df1 Description contains alt text too. * Now download-all works, with the alt-text. * Fails if it does not find an image. Examples: 1350, 1663 * Updated readme. * Updated readme. * Added exclude list to not stumble on comics without images. * my bad. * Updated readme. * Exclude list for image downloads. * Added 1350 to exclude. * Fixed conflicts from exclude list. * Fixed conflicts. * Merged cleanUp. * Merged trimFat * Argparse. And short hand for options. * Check on refactoring. * No more docopts. * Speeling mistake. * Choose image viewer by changing IMAGE_HANDLER variable. More consistent double/single qoute usage.

Prior to this, working directory remained, for example, $WORKING_DIRECTORY/xkcd_archive/1000/, after a comic is downloaded. This is proving inconsistent during testing. If there is a download, the above is the CWD and the program exits. But, if there was no download, the CWD does not change. Remains whereever the command is executed from.

Tests check if there is a file created in the required path. Checks for both the description and image. Two comics are chosen, one regular and one from the exclude list.

tasdikrahman · 2016-07-07T18:13:51Z

xkcd_dl/cli.py

@@ -216,6 +216,7 @@ def download_one(xkcd_dict, xkcd_num):
                        os.rename(file_name, "{description}.jpeg".format(
                            description=new_description)
                        )
+            os.chdir(WORKING_DIRECTORY)


any particular reasons for doing that?

Yes. During testing, if the download succeeds, it does not return to the WORKING_DIRECTORY. And CWD is WD/xkcd_dl/1000/. However, it if the comic is already downloaded, the CWD does not change.

tasdikrahman · 2016-07-07T18:17:33Z

Hey @BlitzKraft

Will keep tabs on further PRs on this and
And hey, good to have you back 😄

BlitzKraft · 2016-07-08T15:29:17Z

Hey @prodicus. unittest seems to be a part of python natively (correct me if I'm wrong). However, pytest is an additional install. I am comparing both the libraries now.

But requiring to install another library just for testing seems like overkill to me.

EDIT: I take back what I said. pytest is way easier to use.

tasdikrahman · 2016-07-21T17:20:32Z

Hey @BlitzKraft

Saw it idling since the last 2 weeks. Thought I would ping you on this. Are you still working on this PR?

BlitzKraft · 2016-07-21T20:38:55Z

I haven't worked on it since. Was a bit busy. Moved to a new city just last Monday. I still intend to work on it.

tasdikrahman · 2016-07-22T08:02:38Z

Was just checking on it. Sure 👍

Kickball · 2016-09-04T20:14:12Z

@BlitzKraft have you had any chance to work on this?

BlitzKraft · 2016-09-04T21:11:14Z

Guys, My apologies. I got busy and haven't worked on it yet. I am not sure when I might get a chance either.

@Kickball, if you are interested, please join in.

tasdikrahman · 2017-05-29T11:57:26Z

Hey guys

@Kickball @BlitzKraft Just checking if you guys are working on this?

Kickball · 2017-05-31T01:46:11Z

Hey @prodicus
I've not been working on this and will not have time in the near future.
Best of luck working on this feature though!

Kickball · 2019-03-15T00:25:54Z

Are we happy to close this; given there has not been any activity on this for 18+ months, this PR has loads of conflicts and its purpose was already achieved in #43?

@BlitzKraft @tasdikrahman

BlitzKraft · 2019-03-15T02:01:41Z

@Kickball Yeah, I second that. Unfortunately, I haven't been able to work on this in a long time.

BlitzKraft and others added 30 commits April 6, 2016 11:21

Description contains alt text too.

55f64f3

index on master: 7b31df1 Description contains alt text too.

b2064b5

WIP on master: 7b31df1 Description contains alt text too.

6db2688

Now download-all works, with the alt-text.

50c555d

Fails if it does not find an image. Examples: 1350, 1663

3b7bda7

Updated readme.

77a136a

Updated readme.

f7bfeff

Added exclude list to not stumble on comics without images.

4a97daa

my bad.

00699e3

Updated readme.

37c159d

Exclude list for image downloads.

e59d586

Added 1350 to exclude.

d31d7ad

Fixed conflicts from exclude list.

621f03d

Merge branch 'master' into excludeList

2e28d0b

Fixed conflicts.

ec82edb

Exclude list added.

5c120bd

Removed the accidentally commited test files.

d081363

Updated README.

40f45f2

Minor cleanUp.

3c2a829

Merge pull request tasdikrahman#21 from BlitzKraft/exList

7f29039

Download continues, if the comic is listed in the exclude list.

Conflicts, again.

440d150

bump version: shipping v0.0.7

45dd08e

Changelog ======== - fixed bug which stopped download of comic when there was no image. - fixed bug which did not download meta data for comic. - Added logo for the package - major refactoring - several bug fixes

Merged cleanUp.

ee64669

Merge pull request #1 from prodicus/master

2e8ca74

Updating my fork of the repo.

Merged trimFat

4d664bb

Argparse. And short hand for options.

184200f

Check on refactoring.

66d1738

No more docopts.

6120692

BlitzKraft and others added 13 commits April 11, 2016 06:23

Merge pull request #2 from prodicus/master

c50a619

Updating my fork of the repo.

bump version: v0.1.0

398ea32

Merge pull request #3 from prodicus/master

a90c7bf

Updating my fork of the repo.

bug: fixed relative import error

db6a582

docs: added --help in README

bca2676

Speeling mistake.

66f1982

Merge pull request #4 from prodicus/master

db0ccdd

Updating my fork of the repo.

Choose image viewer by changing IMAGE_HANDLER variable. More consiste…

5b93c6b

…nt double/single qoute usage.

Merge remote-tracking branch 'upstream/master'

0a62d27

Add unittests

1676841

Tests check if there is a file created in the required path. Checks for both the description and image. Two comics are chosen, one regular and one from the exclude list.

tasdikrahman reviewed Jul 7, 2016
View reviewed changes

tasdikrahman mentioned this pull request May 30, 2017

Adding tests to xkcd-dl #39

Closed

BlitzKraft force-pushed the tests branch from 128b3e6 to 1676841 Compare February 26, 2018 00:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tests #32

Tests #32

BlitzKraft commented Jul 7, 2016 •

edited

Loading

tasdikrahman Jul 7, 2016

BlitzKraft Jul 7, 2016

tasdikrahman commented Jul 7, 2016

BlitzKraft commented Jul 8, 2016 •

edited

Loading

tasdikrahman commented Jul 21, 2016

BlitzKraft commented Jul 21, 2016

tasdikrahman commented Jul 22, 2016

Kickball commented Sep 4, 2016

BlitzKraft commented Sep 4, 2016

tasdikrahman commented May 29, 2017

Kickball commented May 31, 2017

Kickball commented Mar 15, 2019

BlitzKraft commented Mar 15, 2019

Tests #32

Are you sure you want to change the base?

Tests #32

Conversation

BlitzKraft commented Jul 7, 2016 • edited Loading

tasdikrahman Jul 7, 2016

Choose a reason for hiding this comment

BlitzKraft Jul 7, 2016

Choose a reason for hiding this comment

tasdikrahman commented Jul 7, 2016

BlitzKraft commented Jul 8, 2016 • edited Loading

tasdikrahman commented Jul 21, 2016

BlitzKraft commented Jul 21, 2016

tasdikrahman commented Jul 22, 2016

Kickball commented Sep 4, 2016

BlitzKraft commented Sep 4, 2016

tasdikrahman commented May 29, 2017

Kickball commented May 31, 2017

Kickball commented Mar 15, 2019

BlitzKraft commented Mar 15, 2019

BlitzKraft commented Jul 7, 2016 •

edited

Loading

BlitzKraft commented Jul 8, 2016 •

edited

Loading