Test with real git dir #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarmolov
reviewed
May 3, 2018
tests/install.test.js
Outdated
| var fsHelpers = require('../lib/fs-helpers'); | ||
|
|
||
| var SANDBOX_PATH = __dirname + '/tmp-sandbox/'; | ||
| var SANDBOX_PATH = '/tmp/tmp-sandbox/'; |
Owner
There was a problem hiding this comment.
Let's use mktemp -d here. It creates a temporary directory and returs its name.
New code fails with fake .git dir as it doesn't guess, it asks git.
rjmunro
force-pushed
the
feature/improve-tests
branch
from
c1979ee to
195a8c5
Compare
It was running the install, not uninstall command.
Contributor
Author
|
@tarmolov I've fixed the uninstall test and added a new test for a missing hooks folder, so I think the coverage is as high as it can be. I can't figure out a way to cause an exception to cover the last uncovered line. I'm tempted to just remove the try ... catch to get the 100% coverage, but I don't think that would be good practise :-). It may be possible to get the 100% coverage by converting to promises instead of callbacks, as they could handle the exception automatically, but that would require quite a large rework. |
tarmolov
approved these changes
Jun 11, 2018
Owner
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New code fails with fake .git dir as it doesn't guess, it asks git.