Skip to content

fix(web): keep sidebar clicks from scrolling - #201

Merged
tarik02 merged 1 commit into
mainfrom
fix/sidebar-direct-click-scroll
Sep 8, 2026
Merged

fix(web): keep sidebar clicks from scrolling#201
tarik02 merged 1 commit into
mainfrom
fix/sidebar-direct-click-scroll

Conversation

@tarik02

@tarik02 tarik02 commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

What Changed

Plain sidebar thread clicks now use the existing sidebar-navigation path, matching keyboard activation and the behavior originally delivered in #161.

Why

The latest actualization regressed one call site to the generic navigation callback. The active-thread reveal hook then treated direct clicks as external navigation and centered the clicked row.

UI Changes

Before, clicking a visible sidebar thread could scroll it to the center. After, direct sidebar interaction keeps the list position; external navigation still reveals the active thread.

Browser evidence was not captured because browser verification was not requested.

Verification

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for the UI changes
  • I included a video for the interaction change

Implemented with GPT-5.6 Sol in T3 Code.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T13:48:19.924582Z 6762861 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS labels Sep 7, 2026
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.6 KiB 13.5 KiB −26 B (−0.2%) 15.1 KiB
Codex Thread snapshot wire 7.0 KiB 7.0 KiB −4 B (−0.1%) 7.3 KiB
Codex Live turn WebSocket wire 6.5 KiB 6.5 KiB −22 B (−0.3%) 7.8 KiB
Codex Live turn WebSocket decoded 57.0 KiB 57.0 KiB 0 B (0.0%) 66.4 KiB
Codex Live turn messages 8 8 0 (0.0%) 21
Claude Total thread wire 13.6 KiB 13.6 KiB −14 B (−0.1%) 15.1 KiB
Claude Thread snapshot wire 7.1 KiB 7.0 KiB −11 B (−0.2%) 7.3 KiB
Claude Live turn WebSocket wire 6.5 KiB 6.5 KiB −3 B (−0.0%) 7.8 KiB
Claude Live turn WebSocket decoded 57.8 KiB 57.8 KiB 0 B (0.0%) 66.4 KiB
Claude Live turn messages 9 9 0 (0.0%) 21

Baseline: 788a32d · PR result: 6762861 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.9 KiB
  • Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@tarik02
tarik02 merged commit e28ffe5 into main Sep 8, 2026
24 checks passed
@tarik02
tarik02 deleted the fix/sidebar-direct-click-scroll branch September 8, 2026 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant