chore: sync upstream main - #164
Conversation
Co-authored-by: Dara Adedeji <daraadedeji07@gmail.com> Co-authored-by: Ahmed Besic <ahmed-besic@users.noreply.github.com> Co-authored-by: Michael Brown <michaeltbrown.mtb@gmail.com> Co-authored-by: Lars Nieuwenhuis <35393046+lnieuwenhuis@users.noreply.github.com> Co-authored-by: Guilherme Barros <gbarros1095@gmail.com> Co-authored-by: PC <pc@localhost> Co-authored-by: 1xpixi <157762409+1xpixi@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
… (#7538) Co-authored-by: Theo Browne <me@t3.gg>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: Yash Singh <saiansh2525@gmail.com>
Co-authored-by: Julius Marminge <julius@mac.lan>
…395) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Recent scheduled nightlies have been delayed or skipped. Move the nightly cron from minute 7 to minute 38. Keep the existing three-hour interval. This tests a different point in each three-hour window without claiming it will fix GitHub schedule delivery. Authored by GPT-5.6 Sol with the Codex harness.
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Add a mod+shift+p shortcut that pins or unpins the active thread. Ignore the shortcut during terminal focus and when the server does not support thread pinning.
Co-authored-by: codex <codex@users.noreply.github.com>
…mproving launch times (#5769) Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@mac.lan>
Co-authored-by: Shivam Sharma <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Shivam Sharma <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius@mac.lan>
Co-authored-by: Shivam Sharma <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Shivam Sharma <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@mac.lan>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d9b3a431c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| (scopedProjectKeys === null || | ||
| scopedProjectKeys.has(`${thread.environmentId}:${thread.projectId}`) || | ||
| scopedThreadKey(scopeThreadRef(thread.environmentId, thread.id)) === routeThreadKey), | ||
| scopedProjectKeys.has(`${thread.environmentId}:${thread.projectId}`)), |
There was a problem hiding this comment.
Keep externally selected threads in the scoped sidebar
When a project scope is active and navigation comes from the command palette, a jump keybinding, or a deep link to a thread in another project, this filter now removes the routed thread from the default sidebar. The chat opens but the sidebar has no active row; retain routeThreadKey as an exception to the project filter so non-sidebar entry points remain visible.
AGENTS.md reference: AGENTS.md:L69-L71
Useful? React with 👍 / 👎.
| const routeThreadKey = routeThreadRef ? scopedThreadKey(routeThreadRef) : null; | ||
| const markSidebarThreadNavigation = useSidebarActiveThreadScroll({ | ||
| hasThreadRoute: routeTarget !== null, | ||
| routeThreadKey, | ||
| }); | ||
| const routeTargetRef = useRef(routeTarget); |
There was a problem hiding this comment.
Restore scrolling to externally selected sidebar rows
When the command palette, a keybinding, or another external action navigates to a thread row outside the viewport, the default sidebar no longer calls useSidebarActiveThreadScroll and its rows no longer expose the lookup key. A repo-wide search leaves that hook connected only to LegacySidebar, so the default sidebar never scrolls the newly active row into view; reconnect the hook and row markers here.
AGENTS.md reference: AGENTS.md:L69-L71
Useful? React with 👍 / 👎.
| const handleKeyDown = useCallback( | ||
| (event: ReactKeyboardEvent) => { | ||
| const command = resolveShortcutCommand(event, props.keybindings, { | ||
| platform: navigator.platform, | ||
| context: props.getCurrentShortcutContext(), | ||
| }); | ||
| if (command === "thread.rename") { | ||
| event.preventDefault(); | ||
| event.stopPropagation(); | ||
| onStartRename(threadRef, thread.title); | ||
| return; | ||
| } | ||
| if (event.target !== event.currentTarget) return; | ||
| if (event.key !== "Enter" && event.key !== " ") return; |
There was a problem hiding this comment.
Restore F2 rename handling in the default sidebar
With the default sidebar active, focusing a thread row and pressing the configured F2 shortcut no longer starts renaming because this handler now accepts only Enter and Space. The thread.rename binding remains in packages/shared/src/keybindings.ts, while a repo-wide search finds its only remaining sidebar consumer in the opt-in LegacySidebar; restore the rename command handling for this default entry point.
AGENTS.md reference: AGENTS.md:L69-L71
Useful? React with 👍 / 👎.
e832e95 to
3334a36
Compare
3334a36 to
8fa3330
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8fa3330914
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| context: { | ||
| terminalFocus: isTerminalFocused(), | ||
| terminalOpen: routeTerminalOpen, | ||
| modelPickerOpen: isModelPickerOpen(), | ||
| }, |
There was a problem hiding this comment.
Pass preview state to sidebar shortcut matching
When the default sidebar handles a custom thread.previous, thread.next, or thread.jump.* binding conditioned on previewFocus or previewOpen, this partial context makes both values fall back to false in resolveContext. Positive conditions therefore never navigate from the preview, while negated conditions can navigate when the preview is actually focused; the chat-route listener computes these flags but does not execute thread-navigation commands, so it cannot compensate. Preserve the preview context here as LegacySidebar does.
AGENTS.md reference: AGENTS.md:L69-L71
Useful? React with 👍 / 👎.
Sync fork
mainthrough upstream commit3251b7548b4f32c3e47b0e081cd40fd76de13709(chore(release): prepare v0.0.36).Preserves fork-owned workflows, fork versioning/repository metadata, and fork-specific behavior while incorporating upstream changes.
Validation:
git diff --checkand JSON parsing of the touched package manifests.