Skip to content

fix(codex): parse jsonl frames linearly #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarik02 merged 2 commits into from
Aug 27, 2026
Merged

fix(codex): parse jsonl frames linearly #162

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
099cdae
fix(codex): parse jsonl frames linearly
tarik02 Aug 27, 2026
bb4026d
test(codex): cover fragmented jsonl frames
tarik02 Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 25 additions & 8 deletions packages/effect-codex-app-server/src/protocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ export const makeCodexAppServerPatchedProtocol = Effect.fn("makeCodexAppServerPa
const incomingRequests = yield* Queue.unbounded<CodexAppServerIncomingRequest>();
const pending = yield* Ref.make(new Map<string, CodexAppServerPendingRequest>());
const nextRequestId = yield* Ref.make(1);
const remainder = yield* Ref.make("");
const pendingLineParts: Array<string> = [];
const terminationHandled = yield* Ref.make(false);
const scope = yield* Effect.scope;

Expand Down Expand Up @@ -358,20 +358,37 @@ export const makeCodexAppServerPatchedProtocol = Effect.fn("makeCodexAppServerPa
yield* options.stdio.stdin.pipe(
Stream.decodeText(),
Stream.runForEach((chunk) =>
Ref.modify(remainder, (current) => {
const combined = current + chunk;
const lines = combined.split("\n");
const nextRemainder = lines.pop() ?? "";
return [lines.map((line) => line.replace(/\r$/, "")), nextRemainder] as const;
}).pipe(Effect.flatMap((lines) => Effect.forEach(lines, handleLine, { discard: true }))),
Effect.gen(function* () {
let start = 0;
let newline = chunk.indexOf("\n");

while (newline !== -1) {
let line = chunk.slice(start, newline);
if (pendingLineParts.length > 0) {
pendingLineParts.push(line);
line = pendingLineParts.join("");
pendingLineParts.length = 0;
Comment thread
tarik02 marked this conversation as resolved.
}
if (line.endsWith("\r")) {
line = line.slice(0, -1);
}
yield* handleLine(line);
start = newline + 1;
newline = chunk.indexOf("\n", start);
}

if (start < chunk.length) {
pendingLineParts.push(chunk.slice(start));
}
}),
),
Effect.matchEffect({
onFailure: (error) =>
handleTermination(() =>
Effect.succeed(normalizeIncomingError(error, "read-input-stream")),
),
onSuccess: () =>
Ref.get(remainder).pipe(
Effect.sync(() => pendingLineParts.join("")).pipe(
Effect.flatMap((line) => (line.trim().length === 0 ? Effect.void : handleLine(line))),
Effect.matchEffect({
onFailure: (error) => handleTermination(() => Effect.succeed(error)),
Expand Down
Loading