Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using futures 0.3.x and tokio 0.2.9 #1189

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Using futures 0.3.x and tokio 0.2.9 #1189

merged 1 commit into from
Jan 15, 2020

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Jan 14, 2020 •
edited
Loading

Description

Motivation and Context

Closes #1188

How Has This Been Tested?

Existing tests updated and pass

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I'm merging against the development branch
  • I ran cargo-fmt --all before pushing
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@sdbondi sdbondi force-pushed the sb-futures-tokio-upgrade branch 3 times, most recently from 6cd22fa to d151045 Compare January 14, 2020 11:57
CjS77
CjS77 reviewed Jan 14, 2020
View reviewed changes
Copy link
Collaborator

@CjS77 CjS77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice work. Tokio 0.3 is way more readable.

I think we can still have the number of blocking threads as a config by using max_threads in the runtime builder; otherwise looks great.

applications/tari_base_node/src/main.rs Show resolved Hide resolved
applications/tari_base_node/src/main.rs Outdated Show resolved Hide resolved
common/src/configuration.rs Outdated Show resolved Hide resolved
common/src/lib.rs Outdated Show resolved Hide resolved
comms/Cargo.toml Show resolved Hide resolved
comms/src/macros.rs Outdated Show resolved Hide resolved
config/tari_config_sample.toml Outdated Show resolved Hide resolved
infrastructure/test_utils/src/runtime.rs Show resolved Hide resolved
@sdbondi
Using futures 0.3.x and tokio 0.2.9
ea0923b 
- Latest stable version for futures and tokio
- Updated code and tests where applicable
- Removed yamux submodule
- Updated rust to nightly-2020-01-08
CjS77
CjS77 approved these changes Jan 15, 2020
View reviewed changes
Copy link
Collaborator

@CjS77 CjS77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

CjS77 added a commit that referenced this pull request Jan 15, 2020
@CjS77
Using futures 0.3.x and tokio 0.2.9 (#1189)
54f8d2c 
Merge pull request #1189

Using futures 0.3.x and tokio 0.2.9
@CjS77 CjS77 merged commit ea0923b into development Jan 15, 2020
@CjS77 CjS77 deleted the sb-futures-tokio-upgrade branch January 15, 2020 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CjS77 CjS77 CjS77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to futures 0.3.x and tokio 0.2.9
2 participants
@sdbondi @CjS77