Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8 v12.2 Windows patch #13

Merged
merged 3 commits into from
Jan 29, 2024
Merged

V8 v12.2 Windows patch #13

merged 3 commits into from
Jan 29, 2024

Conversation

StefanStojanovic
Copy link

This PR patches V8 v12.2 for Windows, by fixing multiple compilation errors caused by V8 being a Clang-oriented project. There are various types of errors fixed by this going from changing using directives and renaming to overcoming the differences in which Clang and MSVC see templates and metaprogramming.

The changes introduced here are strictly meant as a patch only, so they shouldn't be pushed upstream. Furthermore, the changes will most likely not apply to the next V8 eg. v12.3 directly as a patch (the original V8 update started on v12,1 and after I fixed it and rebased to v12.2 I couldn't apply patches via git apply ..., but had to do it manually with some additional changes). With that in mind, it would be good to finish the V8 update with the current version, so no additional work is needed on this.

To make sure all was working well, I ran the Windows CI. The compilation and testing passed. I didn't test on other platforms since some of them already have issues based on the CI in the original PR.

@targos, I'm open to any questions, suggestions, etc. I left the original 3 commits just for context (the first one was done as part of my work on nodejs/node-v8#271), but when making a patch out of this I see no reason not to squash it.

@targos
Copy link
Owner

targos commented Jan 26, 2024

Thank you @StefanStojanovic. I'm going to squash and merge as-is because I'm not able to review C++ changes.

What I would like to understand is why we have to accept that MSVC can't compile the original code. IIUC, C++ is a standard that all compilers should follow and if something doesn't work with a specific compiler, it's either a bug in the compiler or a bug in the source code.

Also, the V8 project has an MSVC build bot (see https://ci.chromium.org/ui/p/v8/builders/try/v8_win64_msvc_light_compile_rel/b8757869069971882081/overview) that isn't affected by the problem.

@targos targos merged commit 1b8b110 into targos:v8-121 Jan 29, 2024
targos added a commit that referenced this pull request Jan 30, 2024
targos pushed a commit that referenced this pull request Jan 30, 2024
* Nightly patch

* v12.1 patch

* v12.2 patch
@StefanStojanovic StefanStojanovic mentioned this pull request Jan 31, 2024
targos pushed a commit that referenced this pull request Jan 31, 2024
This patches V8 v12.2 for Windows, by fixing multiple compilation
errors caused by V8 being a Clang-oriented project. There are various
types of errors fixed by this going from changing `using` directives
and renaming to overcoming the differences in which Clang and MSVC see
templates and metaprogramming.

The changes introduced here are strictly meant as a patch only, so they
shouldn't be pushed upstream.

Refs: #13
Refs: #14
targos pushed a commit that referenced this pull request Feb 16, 2024
This patches V8 v12.2 for Windows, by fixing multiple compilation
errors caused by V8 being a Clang-oriented project. There are various
types of errors fixed by this going from changing `using` directives
and renaming to overcoming the differences in which Clang and MSVC see
templates and metaprogramming.

The changes introduced here are strictly meant as a patch only, so they
shouldn't be pushed upstream.

Refs: #13
Refs: #14
targos pushed a commit that referenced this pull request Feb 19, 2024
This patches V8 v12.2 for Windows, by fixing multiple compilation
errors caused by V8 being a Clang-oriented project. There are various
types of errors fixed by this going from changing `using` directives
and renaming to overcoming the differences in which Clang and MSVC see
templates and metaprogramming.

The changes introduced here are strictly meant as a patch only, so they
shouldn't be pushed upstream.

Refs: #13
Refs: #14
targos pushed a commit that referenced this pull request Feb 20, 2024
This patches V8 v12.2 for Windows, by fixing multiple compilation
errors caused by V8 being a Clang-oriented project. There are various
types of errors fixed by this going from changing `using` directives
and renaming to overcoming the differences in which Clang and MSVC see
templates and metaprogramming.

The changes introduced here are strictly meant as a patch only, so they
shouldn't be pushed upstream.

Refs: #13
Refs: #14
targos pushed a commit that referenced this pull request Feb 26, 2024
This patches V8 v12.2 for Windows, by fixing multiple compilation
errors caused by V8 being a Clang-oriented project. There are various
types of errors fixed by this going from changing `using` directives
and renaming to overcoming the differences in which Clang and MSVC see
templates and metaprogramming.

The changes introduced here are strictly meant as a patch only, so they
shouldn't be pushed upstream.

Refs: #13
Refs: #14
targos pushed a commit that referenced this pull request Mar 2, 2024
This patches V8 v12.2 for Windows, by fixing multiple compilation
errors caused by V8 being a Clang-oriented project. There are various
types of errors fixed by this going from changing `using` directives
and renaming to overcoming the differences in which Clang and MSVC see
templates and metaprogramming.

The changes introduced here are strictly meant as a patch only, so they
shouldn't be pushed upstream.

Refs: #13
Refs: #14
targos pushed a commit that referenced this pull request Mar 13, 2024
This patches V8 v12.2 for Windows, by fixing multiple compilation
errors caused by V8 being a Clang-oriented project. There are various
types of errors fixed by this going from changing `using` directives
and renaming to overcoming the differences in which Clang and MSVC see
templates and metaprogramming.

The changes introduced here are strictly meant as a patch only, so they
shouldn't be pushed upstream.

Refs: #13
Refs: #14
targos pushed a commit that referenced this pull request Mar 19, 2024
This patches V8 v12.2 for Windows, by fixing multiple compilation
errors caused by V8 being a Clang-oriented project. There are various
types of errors fixed by this going from changing `using` directives
and renaming to overcoming the differences in which Clang and MSVC see
templates and metaprogramming.

The changes introduced here are strictly meant as a patch only, so they
shouldn't be pushed upstream.

Refs: #13
Refs: #14
targos pushed a commit that referenced this pull request Mar 19, 2024
This patches V8 v12.2 for Windows, by fixing multiple compilation
errors caused by V8 being a Clang-oriented project. There are various
types of errors fixed by this going from changing `using` directives
and renaming to overcoming the differences in which Clang and MSVC see
templates and metaprogramming.

The changes introduced here are strictly meant as a patch only, so they
shouldn't be pushed upstream.

Refs: #13
Refs: #14
targos pushed a commit that referenced this pull request Mar 19, 2024
This patches V8 v12.2 for Windows, by fixing multiple compilation
errors caused by V8 being a Clang-oriented project. There are various
types of errors fixed by this going from changing `using` directives
and renaming to overcoming the differences in which Clang and MSVC see
templates and metaprogramming.

The changes introduced here are strictly meant as a patch only, so they
shouldn't be pushed upstream.

Refs: #13
Refs: #14
targos pushed a commit that referenced this pull request Mar 23, 2024
This patches V8 v12.2 for Windows, by fixing multiple compilation
errors caused by V8 being a Clang-oriented project. There are various
types of errors fixed by this going from changing `using` directives
and renaming to overcoming the differences in which Clang and MSVC see
templates and metaprogramming.

The changes introduced here are strictly meant as a patch only, so they
shouldn't be pushed upstream.

Refs: #13
Refs: #14
targos pushed a commit that referenced this pull request Mar 30, 2024
This patches V8 v12.2 for Windows, by fixing multiple compilation
errors caused by V8 being a Clang-oriented project. There are various
types of errors fixed by this going from changing `using` directives
and renaming to overcoming the differences in which Clang and MSVC see
templates and metaprogramming.

The changes introduced here are strictly meant as a patch only, so they
shouldn't be pushed upstream.

Refs: #13
Refs: #14
targos pushed a commit to nodejs/node that referenced this pull request Mar 31, 2024
This patches V8 v12.2 for Windows, by fixing multiple compilation
errors caused by V8 being a Clang-oriented project. There are various
types of errors fixed by this going from changing `using` directives
and renaming to overcoming the differences in which Clang and MSVC see
templates and metaprogramming.

The changes introduced here are strictly meant as a patch only, so they
shouldn't be pushed upstream.

Refs: targos#13
Refs: targos#14
PR-URL: #51362
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
StefanStojanovic added a commit to JaneaSystems/node that referenced this pull request Apr 15, 2024
This patches V8 v12.3 for Windows, by fixing multiple compilation
errors caused by V8 being a Clang-oriented project. There are various
types of errors fixed by this going from changing `using` directives
and renaming to overcoming the differences in which Clang and MSVC see
templates and metaprogramming.

The changes introduced here are strictly meant as a patch only, so they
shouldn't be pushed upstream.

Refs: targos#13
Refs: targos#14
@StefanStojanovic StefanStojanovic mentioned this pull request Apr 15, 2024
StefanStojanovic added a commit to JaneaSystems/node that referenced this pull request Apr 15, 2024
This patches V8 v12.3 for Windows, by fixing multiple compilation
errors caused by V8 being a Clang-oriented project. There are various
types of errors fixed by this going from changing `using` directives
and renaming to overcoming the differences in which Clang and MSVC see
templates and metaprogramming.

The changes introduced here are strictly meant as a patch only, so they
shouldn't be pushed upstream.

Refs: targos#13
Refs: targos#14
targos pushed a commit that referenced this pull request Apr 16, 2024
This patches V8 v12.3 for Windows, by fixing multiple compilation
errors caused by V8 being a Clang-oriented project. There are various
types of errors fixed by this going from changing `using` directives
and renaming to overcoming the differences in which Clang and MSVC see
templates and metaprogramming.

The changes introduced here are strictly meant as a patch only, so they
shouldn't be pushed upstream.

Refs: #13
Refs: #14
targos pushed a commit that referenced this pull request Apr 17, 2024
This patches V8 v12.3 for Windows, by fixing multiple compilation
errors caused by V8 being a Clang-oriented project. There are various
types of errors fixed by this going from changing `using` directives
and renaming to overcoming the differences in which Clang and MSVC see
templates and metaprogramming.

The changes introduced here are strictly meant as a patch only, so they
shouldn't be pushed upstream.

Refs: #13
Refs: #14
Refs: #15
targos pushed a commit that referenced this pull request Apr 18, 2024
This patches V8 v12.3 for Windows, by fixing multiple compilation
errors caused by V8 being a Clang-oriented project. There are various
types of errors fixed by this going from changing `using` directives
and renaming to overcoming the differences in which Clang and MSVC see
templates and metaprogramming.

The changes introduced here are strictly meant as a patch only, so they
shouldn't be pushed upstream.

Refs: #13
Refs: #14
Refs: #15
nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request Apr 19, 2024
This patches V8 v12.3 for Windows, by fixing multiple compilation
errors caused by V8 being a Clang-oriented project. There are various
types of errors fixed by this going from changing `using` directives
and renaming to overcoming the differences in which Clang and MSVC see
templates and metaprogramming.

The changes introduced here are strictly meant as a patch only, so they
shouldn't be pushed upstream.

Refs: targos#13
Refs: targos#14
Refs: targos#15
PR-URL: #52293
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
marco-ippolito pushed a commit to nodejs/node that referenced this pull request Apr 19, 2024
This patches V8 v12.3 for Windows, by fixing multiple compilation
errors caused by V8 being a Clang-oriented project. There are various
types of errors fixed by this going from changing `using` directives
and renaming to overcoming the differences in which Clang and MSVC see
templates and metaprogramming.

The changes introduced here are strictly meant as a patch only, so they
shouldn't be pushed upstream.

Refs: targos#13
Refs: targos#14
Refs: targos#15
PR-URL: #52293
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
StefanStojanovic added a commit to JaneaSystems/node that referenced this pull request Apr 19, 2024
This patches V8 v12.4 for Windows, by fixing multiple compilation
errors caused by V8 being a Clang-oriented project. There are various
types of errors fixed by this going from changing `using` directives
and renaming to overcoming the differences in which Clang and MSVC see
templates and metaprogramming.

The changes introduced here are strictly meant as a patch only, so they
shouldn't be pushed upstream.

Refs: targos#13
Refs: targos#14
Refs: targos#15
StefanStojanovic added a commit to JaneaSystems/node that referenced this pull request Apr 19, 2024
This patches V8 v12.4 for Windows, by fixing multiple compilation
errors caused by V8 being a Clang-oriented project. There are various
types of errors fixed by this going from changing `using` directives
and renaming to overcoming the differences in which Clang and MSVC see
templates and metaprogramming.

The changes introduced here are strictly meant as a patch only, so they
shouldn't be pushed upstream.

Refs: targos#13
Refs: targos#14
Refs: targos#15
@StefanStojanovic StefanStojanovic mentioned this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants