esm: identify parent importing a url with invalid host

PR-URL: nodejs#49736 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
targos · Nov 11, 2023 · efd4e8c · efd4e8c
1 parent aadc39f
commit efd4e8c
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 1 deletion.
diff --git a/lib/internal/modules/esm/resolve.js b/lib/internal/modules/esm/resolve.js
@@ -255,7 +255,16 @@ function finalizeResolution(resolved, base, preserveSymlinks) {
       resolved.pathname, 'must not include encoded "/" or "\\" characters',
       fileURLToPath(base));
 
-  let path = fileURLToPath(resolved);
+  let path;
+  try {
+    path = fileURLToPath(resolved);
+  } catch (err) {
+    const { setOwnProperty } = require('internal/util');
+    setOwnProperty(err, 'input', `${resolved}`);
+    setOwnProperty(err, 'module', `${base}`);
+    throw err;
+  }
+
   if (getOptionValue('--experimental-specifier-resolution') === 'node') {
     let file = resolveExtensionsWithTryExactName(resolved);
 

diff --git a/test/es-module/test-esm-loader-default-resolver.mjs b/test/es-module/test-esm-loader-default-resolver.mjs
@@ -49,4 +49,18 @@ describe('default resolver', () => {
     assert.strictEqual(stdout.trim(), 'index.byoe!');
     assert.strictEqual(stderr, '');
   });
+
+  it('should identify the parent module of an invalid URL host in import specifier', async () => {
+    if (process.platform === 'win32') return;
+
+    const { code, stderr } = await spawnPromisified(execPath, [
+      '--no-warnings',
+      fixtures.path('es-modules', 'invalid-posix-host.mjs'),
+    ]);
+
+    assert.match(stderr, /ERR_INVALID_FILE_URL_HOST/);
+    assert.match(stderr, /file:\/\/hmm\.js/);
+    assert.match(stderr, /invalid-posix-host\.mjs/);
+    assert.strictEqual(code, 1);
+  });
 });
diff --git a/test/fixtures/es-modules/invalid-posix-host.mjs b/test/fixtures/es-modules/invalid-posix-host.mjs
@@ -0,0 +1 @@
+import "file://hmm.js";