Skip to content

Commit

Permalink
v8: do not test v8 with -Werror
Browse files Browse the repository at this point in the history
PR-URL: nodejs#12875
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
addaleax authored and targos committed Jul 21, 2017
1 parent b769749 commit 81895a5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion deps/v8/gypfiles/standalone.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@
'host_clang%': '<(host_clang)',
'target_arch%': '<(target_arch)',
'v8_target_arch%': '<(v8_target_arch)',
'werror%': '-Werror',
'werror%': '',
'use_goma%': '<(use_goma)',
'gomadir%': '<(gomadir)',
'asan%': '<(asan)',
Expand Down
2 changes: 1 addition & 1 deletion deps/v8/gypfiles/toolchain.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
'v8_toolset_for_shell%': 'target',

'host_os%': '<(OS)',
'werror%': '-Werror',
'werror%': '',
# For a shared library build, results in "libv8-<(soname_version).so".
'soname_version%': '',

Expand Down

0 comments on commit 81895a5

Please sign in to comment.