Skip to content

Commit

Permalink
benchmark: refactor util benchmarks
Browse files Browse the repository at this point in the history
This significantly reduces the benchmark runtime. It removes to many
variations that do not provide any benefit and reduces the iterations.

PR-URL: nodejs#22503
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: John-David Dalton <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
  • Loading branch information
BridgeAR authored and targos committed Sep 23, 2018
1 parent 3f0e52e commit 0560cd0
Show file tree
Hide file tree
Showing 8 changed files with 18 additions and 28 deletions.
2 changes: 1 addition & 1 deletion benchmark/util/format.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const inputs = {
};

const bench = common.createBenchmark(main, {
n: [4e6],
n: [1e5],
type: Object.keys(inputs)
});

Expand Down
4 changes: 2 additions & 2 deletions benchmark/util/inspect-array.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ const common = require('../common');
const util = require('util');

const bench = common.createBenchmark(main, {
n: [1e3],
len: [1e5],
n: [5e2],
len: [1e2, 1e5],
type: [
'denseArray',
'sparseArray',
Expand Down
2 changes: 1 addition & 1 deletion benchmark/util/inspect-proxy.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const util = require('util');
const common = require('../common.js');

const bench = common.createBenchmark(main, { n: [1e6] });
const bench = common.createBenchmark(main, { n: [2e4] });

function main({ n }) {
const proxyA = new Proxy({}, { get: () => {} });
Expand Down
4 changes: 2 additions & 2 deletions benchmark/util/inspect.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const opts = {
none: undefined
};
const bench = common.createBenchmark(main, {
n: [2e6],
n: [2e4],
method: [
'Object',
'Object_empty',
Expand Down Expand Up @@ -81,7 +81,7 @@ function main({ method, n, option }) {
benchmark(n, new Error('error'), options);
break;
case 'Array':
benchmark(n, Array(20).fill().map((_, i) => i), options);
benchmark(n, Array(50).fill().map((_, i) => i), options);
break;
case 'TypedArray':
obj = new Uint8Array(Array(50).fill().map((_, i) => i));
Expand Down
29 changes: 9 additions & 20 deletions benchmark/util/normalize-encoding.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,26 +5,23 @@ const assert = require('assert');

const groupedInputs = {
group_common: ['undefined', 'utf8', 'utf-8', 'base64',
'binary', 'latin1', 'ucs-2'],
group_upper: ['UTF-8', 'UTF8', 'UCS2', 'UTF-16LE',
'UTF16LE', 'BASE64', 'UCS-2'],
group_uncommon: ['foo', '1', 'false', 'undefined', '[]', '{}'],
'binary', 'latin1', 'ucs2'],
group_upper: ['UTF-8', 'UTF8', 'UCS2',
'UTF16LE', 'BASE64', 'UCS2'],
group_uncommon: ['foo'],
group_misc: ['', 'utf16le', 'hex', 'HEX', 'BINARY']
};

const inputs = [
'',
'utf8', 'utf-8', 'UTF-8',
'UTF8', 'Utf8', 'uTf-8', 'utF-8',
'ucs2', 'UCS2', 'UcS2',
'ucs-2', 'UCS-2', 'UcS-2',
'utf16le', 'utf-16le', 'UTF-16LE', 'UTF16LE',
'', 'utf8', 'utf-8', 'UTF-8', 'UTF8', 'Utf8',
'ucs2', 'UCS2', 'utf16le', 'UTF16LE',
'binary', 'BINARY', 'latin1', 'base64', 'BASE64',
'hex', 'HEX', 'foo', '1', 'false', 'undefined', '[]', '{}'];
'hex', 'HEX', 'foo', 'undefined'
];

const bench = common.createBenchmark(main, {
input: inputs.concat(Object.keys(groupedInputs)),
n: [1e7]
n: [1e5]
}, {
flags: '--expose-internals'
});
Expand All @@ -39,16 +36,8 @@ function getInput(input) {
return groupedInputs.group_uncommon;
case 'group_misc':
return groupedInputs.group_misc;
case '1':
return [1];
case 'false':
return [false];
case 'undefined':
return [undefined];
case '[]':
return [[]];
case '{}':
return [{}];
default:
return [input];
}
Expand Down
2 changes: 1 addition & 1 deletion benchmark/util/splice-one.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const common = require('../common');

const bench = common.createBenchmark(main, {
n: [1e7],
n: [1e5],
pos: ['start', 'middle', 'end'],
size: [10, 100, 500],
}, { flags: ['--expose-internals'] });
Expand Down
2 changes: 1 addition & 1 deletion benchmark/util/type-check.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const bench = common.createBenchmark(main, {
type: Object.keys(args),
version: ['native', 'js'],
argument: ['true', 'false-primitive', 'false-object'],
n: [5e6]
n: [1e5]
}, {
flags: ['--expose-internals']
});
Expand Down
1 change: 1 addition & 0 deletions test/parallel/test-benchmark-util.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,6 @@ runBenchmark('util',
'pos=start',
'size=1',
'type=',
'len=1',
'version=native'],
{ NODEJS_BENCHMARK_ZERO_ALLOWED: 1 });

0 comments on commit 0560cd0

Please sign in to comment.