Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

No clippy on macOS CI #274

Merged
merged 4 commits into from
Jan 13, 2020
Merged

Conversation

curiousleo
Copy link
Collaborator

@curiousleo curiousleo commented Jan 10, 2020

Partial workaround for #258.

Overview

Cachix does not work on macOS (cachix/cachix#228) and Hydra does not successfully build clippy (NixOS/nixpkgs#77327, NixOS/nixpkgs#77358). As a result, in order to run clippy, we build it from scratch on every CI run on macOS. This adds about 20 minutes of build time.

There is no need to run clippy both on macOS and on Linux. So to circumvent this issue, this PR changes the CI setup slightly so that lints (including clippy) are only run on Linux.

Checklist

  • Updated the documentation (code documentation, command help, ...)
  • Tested the change (unit or integration tests)
  • Amended the changelog in release.nix (see release.nix for instructions)

@curiousleo curiousleo force-pushed the no-clippy-on-macos-ci branch 3 times, most recently from 255100b to 45c692e Compare January 10, 2020 13:42
@curiousleo
Copy link
Collaborator Author

PTAL. The effect of this is to reduce the time nix-build -A allBuildInputs shell.nix > ./shell-inputs takes on macOS from 1244 seconds (20 minutes) to 95 seconds (1.5 minutes).

@curiousleo
Copy link
Collaborator Author

@Profpatsch @grahamc PTAL

@grahamc
Copy link
Contributor

grahamc commented Jan 13, 2020

Go ahead and rebase to resolve conflicts, regenerate the .yml and merge.

@curiousleo curiousleo force-pushed the no-clippy-on-macos-ci branch from 45c692e to f06a999 Compare January 13, 2020 14:26
@grahamc grahamc merged commit 354342b into target:master Jan 13, 2020
@curiousleo curiousleo deleted the no-clippy-on-macos-ci branch January 13, 2020 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants